Skip to content

chore: Unignore HTML files and reformat with oxfmt #19311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logaretm wants to merge 5 commits into
base: develop
Choose a base branch
from
+892 −722
Open

chore: Unignore HTML files and reformat with oxfmt #19311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c6e35e
fix: invalid HTML files
logaretm Feb 11, 2026
dcbb369
chore: upgrade oxfmt
logaretm Feb 12, 2026
62ddf81
chore: run formatter
logaretm Feb 12, 2026
5b52417
fix: broken tests due to formatting changes
logaretm Feb 12, 2026
32a8de8
test: update fixtures
logaretm Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .oxfmtrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@
"dev-packages/browser-integration-tests/fixtures",
"**/test.ts-snapshots/**",
"/.nx/cache",
"/.nx/workspace-data",
"dev-packages/**/*.html",
"dev-packages/**/*.hbs",
"packages/ember/**/*.hbs",
"packages/ember/**/*.html"
"/.nx/workspace-data"
],
"overrides": [
{
Expand Down
4 changes: 2 additions & 2 deletions ...ages/browser-integration-tests/loader-suites/loader/onLoad/keepSentryGlobal/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
<script>
window.Sentry = {_customThingOnSentry: 'customThingOnSentry' };
window.Sentry = { _customThingOnSentry: 'customThingOnSentry' };
</script>
</head>
<body></body>
Expand Down
2 changes: 1 addition & 1 deletion ...packages/browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoad/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoadAndOnLoad/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...ges/browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoadError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
6 changes: 6 additions & 0 deletions dev-packages/browser-integration-tests/results.junit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<testsuites id="" name="" tests="1" failures="0" skipped="0" errors="0" time="3.3956">
<testsuite name="suites/replay/privacyBlock/test.ts" timestamp="2026-02-13T20:07:07.731Z" hostname="chromium" tests="1" failures="0" skipped="0" time="1.969" errors="0">
<testcase name="should allow to manually block elements" classname="suites/replay/privacyBlock/test.ts" time="1.969">
</testcase>
</testsuite>
</testsuites>
Copy link

@cursor cursor bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated JUnit report committed

Low Severity

dev-packages/browser-integration-tests/results.junit.xml appears to be a generated Playwright JUnit artifact, not source. It contains run-specific values like timestamps and durations, so keeping it tracked introduces noisy, non-deterministic diffs and frequent unrelated file churn whenever tests run.

Fix in Cursor Fix in Web

2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/feedback/attachTo/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/feedback/captureFeedback/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
11 changes: 9 additions & 2 deletions ...ackages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand All @@ -7,7 +7,14 @@
<body>
<button id="button1" type="button">Button 1</button>
<button id="button2" type="button">Button 2</button>
<button id="annotated-button" type="button" data-sentry-component="AnnotatedButton" data-sentry-element="StyledButton">Button 3</button>
<button
id="annotated-button"
type="button"
data-sentry-component="AnnotatedButton"
data-sentry-element="StyledButton"
>
Button 3
</button>
<button id="annotated-button-2" type="button" data-sentry-element="StyledButton">Button 4</button>
</body>
</html>
2 changes: 1 addition & 1 deletion ...rowser-integration-tests/suites/integrations/Breadcrumbs/dom/clickWithError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...s/browser-integration-tests/suites/integrations/Breadcrumbs/dom/customEvent/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...browser-integration-tests/suites/integrations/Breadcrumbs/dom/multipleTypes/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...ges/browser-integration-tests/suites/integrations/Breadcrumbs/dom/textInput/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
8 changes: 3 additions & 5 deletions dev-packages/browser-integration-tests/suites/integrations/ContextLines/inline/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
</head>
<body>
<button id="inline-error-btn" onclick="throw new Error('Error with context lines')">Click me</button>
<button id="inline-error-btn" onclick="throw new Error('Error with context lines');">Click me</button>
</body>
<footer>
Some text...
</foot>
<footer>Some text...</footer>
</html>
Comment on lines 6 to 10
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <footer> element is outside the <body> here, which is invalid HTML and can be implicitly relocated by parsers. Moving it inside <body> would make the test fixture HTML well-formed and avoid relying on parser error-correction.

Copilot uses AI. Check for mistakes.
8 changes: 3 additions & 5 deletions dev-packages/browser-integration-tests/suites/integrations/ContextLines/inline/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,12 @@ sentryTest(
{
pre_context: ['<!DOCTYPE html>', '<html>', '<head>', ' <meta charset="utf-8">', ' </head>', ' <body>'],
context_line:
' <button id="inline-error-btn" onclick="throw new Error(\'Error with context lines\')">Click me</button>',
' <button id="inline-error-btn" onclick="throw new Error(\'Error with context lines\');">Click me</button>',
Copy link

@cursor cursor bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctype assertions no longer match templates

Low Severity

The assertions still expect <!DOCTYPE html> in pre_context, but the corresponding templates were reformatted to <!doctype html>. This makes the context-line checks inconsistent with the new fixtures and can cause these integration tests to fail despite unchanged runtime behavior.

Additional Locations (1)

Fix in Cursor Fix in Web

post_context: [
expect.stringContaining('<script'), // this line varies in the test based on tarball/cdn bundle (+variants)
' <footer>',
' Some text...',
' ',
' <footer>Some text...</footer>',
'',
'</footer></body>',
'</body>',
'</html>',
],
},
Expand Down
8 changes: 3 additions & 5 deletions ...ges/browser-integration-tests/suites/integrations/ContextLines/noAddedLines/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
</head>
<body>
<button id="script-error-btn">Click me</button>
<button id="script-error-btn">Click me</button>
</body>
<footer>
Some text...
</foot>
<footer>Some text...</footer>
</html>
Comment on lines 6 to 10
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <footer> element is currently outside the <body>, which is invalid HTML and may be implicitly moved by browsers/tools. If the goal is to fix malformed HTML in tests, move <footer> inside <body> so the template is well-formed.

Copilot uses AI. Check for mistakes.
10 changes: 4 additions & 6 deletions ...ckages/browser-integration-tests/suites/integrations/ContextLines/scriptTag/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
<script>
function throwTestError() {
throw new Error('Error with context lines')
throw new Error('Error with context lines');
}
</script>
</head>
<body>
<button id="inline-error-btn" onclick="throwTestError()">Click me</button>
<button id="inline-error-btn" onclick="throwTestError()">Click me</button>
</body>
<footer>
Some text...
</foot>
<footer>Some text...</footer>
</html>
Comment on lines 11 to 15
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <footer> element is currently placed outside of <body>, which is invalid HTML and can be re-ordered implicitly by parsers (potentially affecting the exact source text/line numbers these tests assert on). Consider moving the footer inside <body> (after the button / injected scripts) so the template is well-formed and deterministic.

Copilot uses AI. Check for mistakes.
16 changes: 7 additions & 9 deletions dev-packages/browser-integration-tests/suites/integrations/ContextLines/scriptTag/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,18 @@ sentryTest(
pre_context: [
' <script>',
' function throwTestError() {',
" throw new Error('Error with context lines')",
" throw new Error('Error with context lines');",
' }',
' </script>',
' </head>',
' <body>',
],
context_line: ' <button id="inline-error-btn" onclick="throwTestError()">Click me</button>',
context_line: ' <button id="inline-error-btn" onclick="throwTestError()">Click me</button>',
post_context: [
expect.stringContaining('<script'), // this line varies in the test based on tarball/cdn bundle (+variants)
' <footer>',
' Some text...',
' ',
' <footer>Some text...</footer>',
'',
'</footer></body>',
'</body>',
'</html>',
],
},
Expand All @@ -64,15 +62,15 @@ sentryTest(
' <script>',
' function throwTestError() {',
],
context_line: " throw new Error('Error with context lines')",
context_line: " throw new Error('Error with context lines');",
post_context: [
' }',
' </script>',
' </head>',
' <body>',
' <button id="inline-error-btn" onclick="throwTestError()">Click me</button>',
' <button id="inline-error-btn" onclick="throwTestError()">Click me</button>',
expect.stringContaining('<script'), // this line varies in the test based on tarball/cdn bundle (+variants)
' <footer>',
' <footer>Some text...</footer>',
],
},
],
Expand Down
2 changes: 1 addition & 1 deletion ...ser-integration-tests/suites/integrations/featureFlags/featureFlags/onError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...wser-integration-tests/suites/integrations/featureFlags/featureFlags/onSpan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
4 changes: 1 addition & 3 deletions ...owser-integration-tests/suites/integrations/featureFlags/growthbook/onError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand All @@ -8,5 +8,3 @@
</body>
<script src="./subject.js"></script>
</html>


4 changes: 1 addition & 3 deletions ...rowser-integration-tests/suites/integrations/featureFlags/growthbook/onSpan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand All @@ -11,5 +11,3 @@
</body>
<script src="./subject.js"></script>
</html>


2 changes: 1 addition & 1 deletion ...ser-integration-tests/suites/integrations/featureFlags/launchdarkly/onError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...wser-integration-tests/suites/integrations/featureFlags/launchdarkly/onSpan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...wser-integration-tests/suites/integrations/featureFlags/openfeature/onError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...owser-integration-tests/suites/integrations/featureFlags/openfeature/onSpan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion .../browser-integration-tests/suites/integrations/featureFlags/statsig/onError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...s/browser-integration-tests/suites/integrations/featureFlags/statsig/onSpan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion .../browser-integration-tests/suites/integrations/featureFlags/unleash/onError/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...s/browser-integration-tests/suites/integrations/featureFlags/unleash/onSpan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
5 changes: 2 additions & 3 deletions dev-packages/browser-integration-tests/suites/ipv6/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
<title></title>
</head>
<body>
</body>
<body></body>
</html>
2 changes: 1 addition & 1 deletion ...ckages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...es/browser-integration-tests/suites/public-api/startSpan/error-async-reject/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...integration-tests/suites/public-api/startSpan/error-async-throw-not-awaited/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion ...ges/browser-integration-tests/suites/public-api/startSpan/error-async-throw/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/browser-integration-tests/suites/replay/attachRawBodyFromRequest/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand All @@ -7,4 +7,3 @@
<h1>attachRawBodyFromRequest Test</h1>
</body>
</html>

2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/replay/bufferModeManual/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/replay/bufferModeReload/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/replay/bufferStalledRequests/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8" />
Expand Down
Loading
Loading