chore: Unignore HTML files and reformat with oxfmt#19311
Open
chore: Unignore HTML files and reformat with oxfmt#19311
Conversation
Contributor
Codecov Results 📊✅ 1 passed | Total: 1 | Pass Rate: 100% | Execution Time: 1.97s 📊 Comparison with Base Branch
All tests are passing successfully. Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
force-pushed
the
awad/migrate-to-oxfmt
branch
from
f9f27f0 to
b2db955
Compare
logaretm
added a commit
that referenced
this pull request
Feb 13, 2026
This PR migrates our formatting tool from `prettier` to `oxfmt` which is part of the oxc toolchain and offers faster checking and format fixing speeds while [maintaining the same coverage](https://x.com/boshen_c/status/2018329440607203471). I created a follow up PR in #19311 to unignore a few rules and fix the associated snapshot tests affected by it. ### Benchmarks Benchmark | Prettier | oxfmt | Speedup -- | -- | -- | -- CI | 45s | 6.0s-7.0s | ~5x-7.5× Local M3 Pro | 22s | 1.22s-1.98s | ~11× --- closes #19223
logaretm
force-pushed
the
awad/reformat-with-oxfmt
branch
from
7d55e6b to
5b52417
Compare
logaretm
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| <testcase name="should have the correct default privacy settings" classname="suites/replay/privacyDefault/test.ts" time="2.745"> | ||
| </testcase> | ||
| </testsuite> | ||
| </testsuites> No newline at end of file |
There was a problem hiding this comment.
Generated JUnit report committed
Low Severity
dev-packages/browser-integration-tests/results.junit.xml appears to be a generated Playwright JUnit artifact, not source. It contains run-specific values like timestamps and durations, so keeping it tracked introduces noisy, non-deterministic diffs and frequent unrelated file churn whenever tests run.
| pre_context: ['<!DOCTYPE html>', '<html>', '<head>', ' <meta charset="utf-8">', ' </head>', ' <body>'], | ||
| context_line: | ||
| ' <button id="inline-error-btn" onclick="throw new Error(\'Error with context lines\')">Click me</button>', | ||
| ' <button id="inline-error-btn" onclick="throw new Error(\'Error with context lines\');">Click me</button>', |
There was a problem hiding this comment.
Doctype assertions no longer match templates
Low Severity
The assertions still expect <!DOCTYPE html> in pre_context, but the corresponding templates were reformatted to <!doctype html>. This makes the context-line checks inconsistent with the new fixtures and can cause these integration tests to fail despite unchanged runtime behavior.
Additional Locations (1)
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to the oxfmt migration to ensure HTML (*.html) and Ember template (*.hbs) files are no longer excluded from formatting, and to update affected test fixtures/snapshots accordingly.
Changes:
- Bump
oxfmtto^0.32.0and updateyarn.lockaccordingly. - Remove
.html/.hbsignore patterns from.oxfmtrc.jsonso those files are formatted. - Reformat a large set of HTML/HBS fixtures and adjust related browser integration test expectations/snapshots.
Reviewed changes
Copilot reviewed 185 out of 203 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates lockfile for oxfmt@0.32.0 and platform bindings. |
| package.json | Bumps oxfmt dev dependency to ^0.32.0. |
| .oxfmtrc.json | Removes ignore patterns so *.html/*.hbs get formatted. |
| packages/ember/tests/index.html | Reformats Ember test runner HTML. |
| packages/ember/tests/dummy/app/index.html | Reformats Ember dummy app HTML. |
| packages/ember/tests/dummy/app/templates/application.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/index.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/replay.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/tracing.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/slow-loading-route.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/slow-loading-route/index.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/with-error.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/with-error/index.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/with-error/error.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/with-loading.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/with-loading/index.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/with-loading/loading.hbs | Reformats Ember template fixture. |
| packages/ember/tests/dummy/app/templates/components/test-section.hbs | Reformats Ember component template fixture. |
| packages/ember/tests/dummy/app/templates/components/slow-loading-list.hbs | Reformats Ember component template fixture. |
| packages/ember/tests/dummy/app/templates/components/slow-loading-gc-list.hbs | Reformats Ember component template fixture. |
| packages/ember/tests/dummy/app/components/link.hbs | Reformats Ember component template fixture. |
| dev-packages/e2e-tests/test-applications/vue-3/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/vue-tanstack-router/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/solid/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/solid-tanstack-router/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-send-to-sentry/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-router-7-lazy-routes/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-router-7-cross-usage/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-router-6/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-router-6-use-routes/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-router-6-descendant-routes/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-router-5/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-create-memory-router/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-create-hash-router/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-create-browser-router/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-19/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/react-17/public/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/node-profiling-electron/index.html | Reformats E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/sveltekit-2/src/app.html | Reformats SvelteKit app HTML fixture. |
| dev-packages/e2e-tests/test-applications/sveltekit-2.5.0-twp/src/app.html | Reformats SvelteKit app HTML fixture. |
| dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/src/app.html | Reformats SvelteKit app HTML fixture. |
| dev-packages/e2e-tests/test-applications/sveltekit-2-kit-tracing/src/app.html | Reformats SvelteKit app HTML fixture. |
| dev-packages/e2e-tests/test-applications/sveltekit-cloudflare-pages/src/app.html | Reformats SvelteKit app HTML fixture. |
| dev-packages/e2e-tests/test-applications/angular-17/src/index.html | Reformats Angular app HTML fixture. |
| dev-packages/e2e-tests/test-applications/angular-18/src/index.html | Reformats Angular app HTML fixture. |
| dev-packages/e2e-tests/test-applications/angular-19/src/index.html | Reformats Angular app HTML fixture. |
| dev-packages/e2e-tests/test-applications/create-react-app/public/index.html | Reformats CRA app HTML fixture. |
| dev-packages/e2e-tests/test-applications/default-browser/public/index.html | Reformats default-browser HTML fixture (whitespace cleanup). |
| dev-packages/e2e-tests/test-applications/ember-classic/app/index.html | Reformats Ember classic E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/application.hbs | Reformats Ember classic E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/index.hbs | Reformats Ember classic E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/replay.hbs | Reformats Ember classic E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/tracing.hbs | Reformats Ember classic E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/slow-loading-route.hbs | Reformats Ember classic E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/slow-loading-route/index.hbs | Reformats Ember classic E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/components/test-section.hbs | Reformats Ember classic E2E component template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/components/slow-loading-list.hbs | Reformats Ember classic E2E component template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/templates/components/slow-loading-gc-list.hbs | Reformats Ember classic E2E component template fixture. |
| dev-packages/e2e-tests/test-applications/ember-classic/app/components/link.hbs | Reformats Ember classic E2E component template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/index.html | Reformats Ember embroider E2E app HTML fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/templates/application.hbs | Reformats Ember embroider E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/templates/index.hbs | Reformats Ember embroider E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/templates/tracing.hbs | Reformats Ember embroider E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/templates/slow-loading-route.hbs | Reformats Ember embroider E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/templates/slow-loading-route/index.hbs | Reformats Ember embroider E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/templates/slow-loading-route/loading.hbs | Reformats Ember embroider E2E template fixture. |
| dev-packages/e2e-tests/test-applications/ember-embroider/app/components/error-button.hbs | Reformats Ember embroider component template fixture. |
| dev-packages/browser-integration-tests/utils/defaults/template.html | Reformats default browser integration test HTML template. |
| dev-packages/browser-integration-tests/suites/integrations/ContextLines/scriptTag/template.html | Reformats ContextLines HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/ContextLines/scriptTag/test.ts | Updates ContextLines assertions to match reformatted fixture output. |
| dev-packages/browser-integration-tests/suites/integrations/ContextLines/inline/template.html | Reformats ContextLines HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/ContextLines/inline/test.ts | Updates ContextLines assertions to match reformatted fixture output. |
| dev-packages/browser-integration-tests/suites/integrations/ContextLines/noAddedLines/template.html | Reformats ContextLines HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/template.html | Reformats Breadcrumbs HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/clickWithError/template.html | Reformats Breadcrumbs HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/customEvent/template.html | Reformats Breadcrumbs HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/multipleTypes/template.html | Reformats Breadcrumbs HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/textInput/template.html | Reformats Breadcrumbs HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/onError/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/onSpan/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onError/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/growthbook/onSpan/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/onError/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/onSpan/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/onError/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/onSpan/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/onError/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/statsig/onSpan/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/unleash/onError/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/integrations/featureFlags/unleash/onSpan/template.html | Reformats feature-flags HTML fixture. |
| dev-packages/browser-integration-tests/suites/feedback/attachTo/template.html | Reformats feedback HTML fixture. |
| dev-packages/browser-integration-tests/suites/feedback/captureFeedback/template.html | Reformats feedback HTML fixture. |
| dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/template.html | Reformats feedback HTML fixture. |
| dev-packages/browser-integration-tests/suites/stacktraces/template.html | Reformats stacktraces HTML fixture. |
| dev-packages/browser-integration-tests/suites/ipv6/template.html | Reformats ipv6 HTML fixture. |
| dev-packages/browser-integration-tests/suites/sessions/start-session/template.html | Fixes malformed HTML anchor tag + reformats fixture. |
| dev-packages/browser-integration-tests/suites/sessions/initial-scope/template.html | Fixes malformed HTML anchor tag + reformats fixture. |
| dev-packages/browser-integration-tests/suites/sessions/page-lifecycle/template.html | Reformats sessions HTML fixture. |
| dev-packages/browser-integration-tests/suites/sessions/route-lifecycle/template.html | Reformats sessions HTML fixture. |
| dev-packages/browser-integration-tests/suites/sessions/update-session/template.html | Reformats sessions HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/privacyBlock/template.html | Reformats replay privacy HTML fixture (introduces whitespace/newlines in SVG markup). |
| dev-packages/browser-integration-tests/suites/replay/privacyDefault/template.html | Reformats replay privacy HTML fixture (SVG/inline styles). |
| dev-packages/browser-integration-tests/suites/replay/privacyBlock/test.ts-snapshots/privacy-chromium.json | Updates replay snapshot expectation due to fixture formatting changes. |
| dev-packages/browser-integration-tests/suites/replay/privacyInput/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/privacyInputMaskAll/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/replayShim/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/replayIntegrationShim/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/captureReplay/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/captureReplayFromReplayPackage/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/captureReplayOffline/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/captureConsoleLog/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/captureComponentName/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/requests/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/sampling/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/sessionExpiry/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/sessionInactive/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/sessionMaxAge/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/throttleBreadcrumbs/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/unicode/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/slowClick/template.html | Reformats replay HTML fixture (inline JS tweak). |
| dev-packages/browser-integration-tests/suites/replay/slowClick/error/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/exceptions/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/errors/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/errorResponse/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/eventBufferError/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/fileInput/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/flushing/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/keyboardEvents/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/largeMutations/defaultOptions/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/largeMutations/mutationLimit/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/minReplayDuration/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/maxReplayDuration/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/multiple-pages/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/multiple-pages/page-0.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/bufferModeManual/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/bufferModeReload/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/bufferStalledRequests/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/canvas/template.html | Reformats replay canvas HTML fixture. |
| dev-packages/browser-integration-tests/suites/replay/canvas/records/template.html | Reformats replay canvas HTML fixture + inline script formatting. |
| dev-packages/browser-integration-tests/suites/replay/canvas/manualSnapshot/template.html | Reformats replay canvas HTML fixture + inline script formatting. |
| dev-packages/browser-integration-tests/suites/replay/attachRawBodyFromRequest/template.html | Reformats replay HTML fixture. |
| dev-packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw/template.html | Reformats public-api HTML fixture. |
| dev-packages/browser-integration-tests/suites/public-api/startSpan/error-async-throw-not-awaited/template.html | Reformats public-api HTML fixture. |
| dev-packages/browser-integration-tests/suites/public-api/startSpan/error-async-reject/template.html | Reformats public-api HTML fixture. |
| dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/template.html | Reformats old-sdk-interop HTML fixture. |
| dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/template.html | Reformats old-sdk-interop HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-headers/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload-meta/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/startNewTrace/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/startNewTraceSampling/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/tracing-without-performance/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/tracing-without-performance-headers/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/request/fetch-strip-query-and-fragment/template.html | Reformats tracing request HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/request/fetch-trace-header-merging/template.html | Reformats tracing request HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/request/xhr-strip-query-and-fragment/template.html | Reformats tracing request HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/connection-rtt/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/element-timing/template.html | Reformats tracing metrics HTML fixture (void tag formatting). |
| dev-packages/browser-integration-tests/suites/tracing/metrics/handlers-lcp/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-resource-spans/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-cls/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-cls-standalone-spans/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-fp-fcp/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-late/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-navigate/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-inp-parametrized-late/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-lcp-standalone-spans/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/metrics/web-vitals-ttfb/template.html | Reformats tracing metrics HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/meta/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/twp-errors-meta/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions-navigation-click/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/backgroundtab-custom/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/backgroundtab-pageload/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/meta/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/interaction-spans/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/custom-trace/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/tracesSampler-precedence/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-animation-frame-before-navigation/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-animation-frame-disabled/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-animation-frame-enabled/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-animation-frame-non-chromium/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-tasks-before-navigation/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-tasks-disabled/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-tasks-enabled/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-tasks-no-animation-frame/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/long-tasks-and-animation-frame-enabled/template.html | Reformats tracing HTML fixture. |
| dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegrationShim/template.html | Reformats shim HTML fixture. |
| dev-packages/browser-integration-tests/loader-suites/loader/onLoad/keepSentryGlobal/template.html | Reformats loader HTML fixture. |
| dev-packages/browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoad/template.html | Reformats loader HTML fixture. |
| dev-packages/browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoadAndOnLoad/template.html | Reformats loader HTML fixture. |
| dev-packages/browser-integration-tests/loader-suites/loader/onLoad/sentryOnLoadError/template.html | Reformats loader HTML fixture. |
| dev-packages/browser-integration-tests/results.junit.xml | Adds a generated JUnit report file (should not be committed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
10
| <testsuites id="" name="" tests="2" failures="0" skipped="0" errors="0" time="4.057123"> | ||
| <testsuite name="suites/replay/privacyBlock/test.ts" timestamp="2026-02-12T21:36:46.863Z" hostname="chromium" tests="1" failures="0" skipped="0" time="2.744" errors="0"> | ||
| <testcase name="should allow to manually block elements" classname="suites/replay/privacyBlock/test.ts" time="2.744"> | ||
| </testcase> | ||
| </testsuite> | ||
| <testsuite name="suites/replay/privacyDefault/test.ts" timestamp="2026-02-12T21:36:46.863Z" hostname="chromium" tests="1" failures="0" skipped="0" time="2.745" errors="0"> | ||
| <testcase name="should have the correct default privacy settings" classname="suites/replay/privacyDefault/test.ts" time="2.745"> | ||
| </testcase> | ||
| </testsuite> | ||
| </testsuites> No newline at end of file |
There was a problem hiding this comment.
results.junit.xml looks like a generated Playwright JUnit reporter output (timestamps, durations, etc.) and will churn on every test run. It should not be committed—please remove it from the PR and add an ignore rule for this file/path (e.g. under dev-packages/**/results.junit.xml or similar).
Suggested change
| <testsuites id="" name="" tests="2" failures="0" skipped="0" errors="0" time="4.057123"> | |
| <testsuite name="suites/replay/privacyBlock/test.ts" timestamp="2026-02-12T21:36:46.863Z" hostname="chromium" tests="1" failures="0" skipped="0" time="2.744" errors="0"> | |
| <testcase name="should allow to manually block elements" classname="suites/replay/privacyBlock/test.ts" time="2.744"> | |
| </testcase> | |
| </testsuite> | |
| <testsuite name="suites/replay/privacyDefault/test.ts" timestamp="2026-02-12T21:36:46.863Z" hostname="chromium" tests="1" failures="0" skipped="0" time="2.745" errors="0"> | |
| <testcase name="should have the correct default privacy settings" classname="suites/replay/privacyDefault/test.ts" time="2.745"> | |
| </testcase> | |
| </testsuite> | |
| </testsuites> | |
| <?xml version="1.0" encoding="UTF-8"?> | |
| <!-- | |
| Placeholder JUnit results file. | |
| Real Playwright JUnit XML results are generated at test time and should | |
| not be committed to version control. Configure your test and VCS settings | |
| so that dev-packages/**/results.junit.xml is ignored. | |
| --> |
Comment on lines
11
to
15
| <body> | ||
| <button id="inline-error-btn" onclick="throwTestError()">Click me</button> | ||
| <button id="inline-error-btn" onclick="throwTestError()">Click me</button> | ||
| </body> | ||
| <footer> | ||
| Some text... | ||
| </foot> | ||
| <footer>Some text...</footer> | ||
| </html> |
There was a problem hiding this comment.
The <footer> element is currently placed outside of <body>, which is invalid HTML and can be re-ordered implicitly by parsers (potentially affecting the exact source text/line numbers these tests assert on). Consider moving the footer inside <body> (after the button / injected scripts) so the template is well-formed and deterministic.
Comment on lines
6
to
10
| <body> | ||
| <button id="script-error-btn">Click me</button> | ||
| <button id="script-error-btn">Click me</button> | ||
| </body> | ||
| <footer> | ||
| Some text... | ||
| </foot> | ||
| <footer>Some text...</footer> | ||
| </html> |
There was a problem hiding this comment.
The <footer> element is currently outside the <body>, which is invalid HTML and may be implicitly moved by browsers/tools. If the goal is to fix malformed HTML in tests, move <footer> inside <body> so the template is well-formed.
Comment on lines
6
to
10
| <body> | ||
| <button id="inline-error-btn" onclick="throw new Error('Error with context lines')">Click me</button> | ||
| <button id="inline-error-btn" onclick="throw new Error('Error with context lines');">Click me</button> | ||
| </body> | ||
| <footer> | ||
| Some text... | ||
| </foot> | ||
| <footer>Some text...</footer> | ||
| </html> |
There was a problem hiding this comment.
The <footer> element is outside the <body> here, which is invalid HTML and can be implicitly relocated by parsers. Moving it inside <body> would make the test fixture HTML well-formed and avoid relying on parser error-correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #19200 by:
*.hbsand*.htmlfilesI initially thought it was some extra stuff done by oxfmt, but its just we didn't have those file extensions in the extension list for the format script. so, its the same output if prettier ran over those files.
closes #19223