Repository navigation
feat: type the Google loyalty mapping on template designs - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
design.googletoTemplateDesign, derived from the platform's OpenAPI spec (new exported typeTemplateDesignGoogle). Also exportsTemplateLocation, whichTemplateDesign.locationsalready used but which could not be imported by name:loyaltyPoints/secondaryLoyaltyPoints:{ fieldKey, label }, a template field shown as the Google Wallet loyalty balanceaccountNameFieldKey: the field Google shows as the card holder's nameSpec re-synced from platform main (ab50a03);
openapi.jsonis byte-identical to the platform's. README and a minor changeset included.Why
The API now accepts
design.google(live in production), and SDK users need the type to send it.Testing
Type test for the new shape (valid mapping, and a non-string label is rejected). lint, type-check, test, build, attw, publint, generate:check and test:ecosystem all pass.
Compatibility
Additive: one optional property and two newly exported types. Existing exports are unchanged and the compat suite passes. The platform side is already deployed.