Repository navigation
Add template republish - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12 (
feat/google-loyalty-design): both touch the generated files. GitHub retargets this tomainwhen #12 merges.What
templates.republish(id, options?)andtemplates.retrieveRepublish(id, republishId)for the new platform endpoints.republishsends anIdempotency-Key(generated, oroptions.idempotencyKey).TemplateRepublishandTemplateRepublishedEventtypes.PassDelivery.apple.retrying/google.retrying,template.republishedinPASSMINT_EVENT_TYPES.republish_in_progressis thrown asPassmintRateLimitErrorstraight away. The client never retries 429s, which matters because this one can last minutes. Pinned by a test.Why
lin.ky edits venue templates and needs those edits to reach cards already issued.
Testing
lint, type-check, test (incl. 0.4.0 compat types), build, attw, publint, generate:check, test:ecosystem.
openapi.jsonis byte-identical to the platform'sorigin/main. Event-type pins in unit tests, the ecosystem smoke tests and the mock server now includetemplate.republished.Compatibility
Minor, additive. Call shapes from 0.5.0/0.6.0 are unchanged, and
PassmintEventstill describes pass events. Things to know (all in the changeset):PassmintEventType/Event['type']gaintemplate.republished, so exhaustive switches will flag it.PASSMINT_EVENT_TYPESgains an entry at runtime; code subscribing with[...PASSMINT_EVENT_TYPES]will receive it.template.republishedis only sent to endpoints subscribed by name, never"*".pass.update_failednow fires only for permanent failures or exhausted retries;delivery.<platform>.retryingis new.Release
Publish only after the platform deploy that serves the endpoints is live. No merge or publish without Alex.