Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 85.56% 86.24% +0.68%
==========================================
Files 32 32
Lines 1905 1905
==========================================
+ Hits 1630 1643 +13
+ Misses 275 262 -13 🚀 New features to boost your workflow:
|
Collaborator
|
Currently PackageInfo.g has GAP >= 4.12 and the minimal test is failing. |
Member
Author
|
No, I think the problem is flaky tests. I am looking into a more permanent solution right now... |
fingolfin
marked this pull request as ready for review
July 18, 2026 23:31
This reverts commit 9a1dabb.
Install that version explicitly so the minimal GAP job does not use the older bundled curlInterface, which silently ignores maxTime. Co-authored-by: Codex <codex@openai.com>
fingolfin
changed the title
Member
Author
|
@cdwensley this should be ready now :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9a1dabb / relands PR #95.
Moreover, it changes utils to require curlInterface 2.4.0, as that is needed for timeout support in
Download.