Use local server for download tests#99
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 85.21% 85.56% +0.34%
==========================================
Files 32 32
Lines 1867 1905 +38
==========================================
+ Hits 1591 1630 +39
+ Misses 276 275 -1
🚀 New features to boost your workflow:
|
Member
Author
|
This should be much more reliable |
Replace live network assertions with a forked HTTP server provided by the IO test dependency. Teach the SingleHTTPRequest adapter to handle explicit ports so every backend can use the ephemeral local address. Keep the public HTTPS transcript as non-executable documentation. Co-authored-by: Codex <codex@openai.com>
fingolfin
force-pushed
the
mh/custom-http-server
branch
from
July 17, 2026 21:32
095e711 to
4ef18fb
Compare
Exercise URLs without paths, authority-only fragments, and malformed authorities in the SingleHTTPRequest adapter tests. Co-authored-by: Codex <codex@openai.com>
Member
Author
|
Assuming the tests are (again) green this can should be merged. Then afterwards I can update PR #98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace live network assertions with a forked HTTP server provided by
the IO test dependency. Teach the SingleHTTPRequest adapter to handle
explicit ports so every backend can use the ephemeral local address.
Keep the public HTTPS transcript as non-executable documentation.
Co-authored-by: Codex codex@openai.com
Closes #97