wallet: retire the two debug-mode experiments, and say what actually clears a stuck wallet - #42
Merged
Conversation
…clears a stuck wallet Reverts #40 (debug mode: publish the request but do not open the wallet) and #41 (debug mode: hand the wallet no return address). Both were diagnostics, and they did their job: four device logs showed MetaMask wedged on its splash screen on every WARM resume -- by our deep link, by the manual button, by recent apps, with the redirect on, with it off -- and working on every COLD launch, with or without a deep link. That isolates the hang to MetaMask's own resume on that phone. Nothing in the app distinguishes the working case from the failing one. Left in, the two toggles would give anyone who enables debug mode for support an altered wallet flow for no further gain. Untouched, deliberately: the return path. #36/#38's wake and #39's park-on-hidden are what took the return from the wallet from 8.6 s to under a second, and the same logs confirm it three times over. `git revert` of exactly the two experiment commits; relayWake.ts and diag.ts are not in the diff. The stuck-wallet hint stops blaming Android's battery restriction, which the same logs ruled out (the wedge appears within seconds of backgrounding; battery restriction acts over minutes). It now says the thing every log showed working: close the wallet from recent apps and open it again -- from its icon or with the button -- and it shows the request. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013BpqXrkEPA9odTyRdK5Mnx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the two debug-mode experiments
Reverts #40 (debug mode: publish the request but don't open the wallet) and #41 (debug mode: hand the wallet no return address). Both were diagnostics, and they did their job. Four device logs showed MetaMask wedged on its splash screen on every warm resume — via our deep link, via the manual button, via recent apps, with the redirect on, with it off — and working on every cold launch, with or without a deep link. That isolates the hang to MetaMask's own resume on that phone; nothing in the app distinguishes the working case from the failing one. Left in, the toggles would give anyone who enables debug mode for support an altered wallet flow for no further gain.
Untouched, deliberately: the return path. #36/#38's wake and #39's park-on-hidden are what took the return from the wallet from 8.6 s to under a second, confirmed three times in the same logs. This is a
git revertof exactly the two experiment commits —relayWake.tsanddiag.tsare not in the diff.The stuck-wallet hint says what actually works
It stops blaming Android's battery restriction, which the same logs ruled out (the wedge appears within seconds of backgrounding; battery restriction acts over minutes). It now says the thing every log showed working: close the wallet from recent apps and open it again — from its icon, or with the button — and it shows the request. Same correction on docs.fx.land in functionland/docs#180.
Testing
npm test --workspacesclean; typecheck and lint clean. The reverted tests go with the reverted code; every relay-wake test stays and passes.🤖 Generated with Claude Code
https://claude.ai/code/session_013BpqXrkEPA9odTyRdK5Mnx