Skip to content

Render a dimmed ✓ instead of blank space for deselected checkboxes #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shouze merged 1 commit into from
Aug 23, 2026
Merged

Render a dimmed ✓ instead of blank space for deselected checkboxes #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ export function renderGroups(
);
if (repoRowIndex >= 0 && repoRowIndex < scrollOffset) {
const g = groups[cursorRow.repoIndex];
const checkbox = g.repoSelected ? pc.green("✓") : " ";
const checkbox = g.repoSelected ? pc.green("✓") : pc.dim("✓");
// Fix: clip to termWidth so the sticky line never wraps — see issue #105.
Comment thread
shouze marked this conversation as resolved.
stickyRepoLine = clipToWidth(
pc.dim(`▲ ${checkbox} ${pc.bold(g.repoFullName)} ${pc.dim(buildMatchCountLabel(g))}`),
Expand Down Expand Up @@ -564,10 +564,8 @@ export function renderGroups(

if (row.type === "repo") {
const arrow = group.folded ? pc.magenta("▸") : pc.magenta("▾");
// ✓ for selected, space for deselected — keeps the line clean while a
// green checkmark clearly signals selection. The space preserves column
// alignment so the repo name always starts at the same offset.
const checkbox = group.repoSelected ? pc.green("✓") : " ";
// Green ✓ for selected; dimmed ✓ for deselected — provides a clickable target in both states.
const checkbox = group.repoSelected ? pc.green("✓") : pc.dim("✓");
// On cursor rows, use bold+white for the repo name (dark bg applied
// to the whole line via renderActiveLine; no inline bgMagenta needed).
// On inactive rows, use bright purple (same as the bar) in bold.
Expand Down Expand Up @@ -602,7 +600,7 @@ export function renderGroups(
const ei = row.extractIndex!;
const match = group.matches[ei];
const selected = group.extractSelected[ei];
const checkbox = selected ? pc.green("✓") : " ";
const checkbox = selected ? pc.green("✓") : pc.dim("✓");
const seg = match.textMatches[0]?.matches[0];
const locSuffix = seg ? `:${seg.line}:${seg.col}` : "";
// Active extract row: locSuffix uses bold+white (same as path) for
Expand Down
Loading