Render a dimmed ✓ instead of blank space for deselected checkboxes - #171
Merged
Conversation
- Replace empty space with pc.dim('✓') at three render sites in src/render.ts:
repo sticky line, repo row, and extract row
- Maintains column alignment while providing a visible, clickable target
- Improves UI consistency for mouse support (issue #169)
- All tests pass; no formatting or knip issues
|
Coverage after merging feat/mouse-ui-checkbox into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TUI rendering in github-code-search to show a dimmed checkmark (✓) for deselected checkboxes instead of a blank space, making selection affordances more visually consistent across the UI.
Changes:
- Render
pc.dim("✓")for deselected repo checkboxes in the sticky repo header line. - Render
pc.dim("✓")for deselected repo rows and extract rows.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves UI consistency by rendering a dimmed ✓ character instead of a blank space for deselected checkboxes. This provides visual feedback that a checkbox exists (and is clickable) even when not selected.
Changes
pc.dim("✓")instead of" "for deselected repository checkboxes in three locations:How did you verify your code works?
Closes #169