fix: rename hideArchived props on sponsor forms and pages tabs

[tomrndom]

ref: https://app.clickup.com/t/86b9wgk9y

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

• Bug Fixes
  • Fixed archive filter state not correctly refreshing when closing sponsor forms
  • Fixed archive filter state not correctly updating after deleting sponsor pages

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58c75cfb-bfa6-4fac-9c7d-c18258957e4d

📥 Commits

Reviewing files that changed from the base of the PR and between 2a07f4e and 0f604bd.

📒 Files selected for processing (2)

• src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js
• src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js

---

📝 Walkthrough

Walkthrough

This PR fixes incorrect variable references in two sponsor tab components. The handleCloseCustomizedPopup function in the sponsor forms tab and the handleCustomizedDelete function in the sponsor pages tab now pass the showArchived prop value to their refresh calls instead of the undefined hideArchived reference.

Changes

Archived Filter Parameter Fix

Layer / File(s)	Summary
Archive filter parameter fix in form and page refresh flows src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js, src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js	In sponsor-forms-tab, handleCloseCustomizedPopup now passes showArchived to getSponsorManagedForms and getSponsorCustomizedForms. In sponsor-pages-tab, handleCustomizedDelete now passes showArchived to getSponsorCustomizedPages. Both changes align the archived-filter argument with the component's checkbox state rather than referencing an undefined hideArchived variable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• fntechgit/summit-admin#869: Both PRs modify the same sponsor tabs (sponsor-forms-tab and sponsor-pages-tab) to fix the archived-filter used when refreshing lists—replacing the incorrect hideArchived with showArchived in close/delete refresh flows.
• fntechgit/summit-admin#908: Both PRs fix the same bug by replacing uses of the incorrect hideArchived variable with showArchived in sponsor-related components.
• fntechgit/summit-admin#876: Both PRs make the same code-level fix replacing an incorrect/undefined hideArchived usage with the correct showArchived call in sponsor-related components.

Suggested reviewers

• smarcet

Poem

🐰 A variable mix-up, now set right,
showArchived shines where hideArchived once tried,
Forms and pages refresh with correct sight,
The sponsor tabs now filter with pride! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: renaming hideArchived props to showArchived in sponsor forms and pages tabs components.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/sponsor-pages-form-archived

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[smarcet]

LGTM