Skip to content

fix: reload managed page on customized pages delete #935

Merged
smarcet merged 2 commits into
masterfrom
fix/reload-tables-customized-pages
May 14, 2026
Merged

fix: reload managed page on customized pages delete #935
smarcet merged 2 commits into
masterfrom
fix/reload-tables-customized-pages

Conversation

@tomrndom
Copy link
Copy Markdown

@tomrndom tomrndom commented May 14, 2026

ref: https://app.clickup.com/t/86b9wgk9y

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Deleting a customized sponsor form or page now properly refreshes both customized and managed items lists to ensure data consistency.
    • Current filters, search terms, and pagination settings are preserved after deletion.

Review Change Stack

tomrndom added 2 commits May 14, 2026 10:05
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet May 14, 2026 13:09
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d4f45dfc-d16a-4d65-8c20-9bef09f9ee23

📥 Commits

Reviewing files that changed from the base of the PR and between 8cc1910 and b13f8f8.

📒 Files selected for processing (2)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js

📝 Walkthrough

Walkthrough

After deleting a customized sponsor form or page, handleCustomizedDelete in both tabs now refreshes both the customized and managed lists. The refresh uses direct state property access for pagination and sort settings instead of destructured variables, and passes the showArchived flag consistently.

Changes

Delete handler refresh logic

Layer / File(s) Summary
Customized delete handlers refresh both lists and use direct state references
src/pages/sponsors/sponsor-page/tabs/sponsor-forms-tab/index.js, src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js
After deletion, both customized and managed lists are reloaded. Pagination, sort, and showArchived parameters are read directly from Redux state (customizedForms.* or customizedPages.*) instead of destructured variables.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • fntechgit/summit-admin#876: Updates sponsor-forms-tab reload logic to use the correct showArchived prop name and refresh both customized and archived lists on delete.
  • fntechgit/summit-admin#932: Ensures archived-filter consistency across both forms and pages tabs by using showArchived instead of hideArchived.
  • fntechgit/summit-admin#886: Introduces managed forms refresh logic in the forms tab, which this PR extends to also refresh managed forms in handleCustomizedDelete.

Suggested reviewers

  • smarcet
  • romanetar

Poem

🐰 When forms take flight and pages part,
Two tabs refresh with beating heart,
Both lists dance true, both states align—
No more half-measures, all shine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects one of the main changes in the pull request—reloading managed pages after customizing pages deletion. However, it doesn't mention the equally important change to sponsor forms tab, which is addressed in a separate commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/reload-tables-customized-pages

Comment @coderabbitai help to get the list of available commands and usage tips.

@tomrndom tomrndom changed the title Fix/reload tables customized pages fix: reload managed page on customized pages delete May 14, 2026
Copy link
Copy Markdown

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit de12ac1 into master May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants