Skip to content

web testing: use "--no-sandbox" and implement some cleanup logic #10058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srawlins wants to merge 1 commit into
base: master
Choose a base branch
from
+63 −39
Open

web testing: use "--no-sandbox" and implement some cleanup logic #10058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 63 additions & 39 deletions packages/devtools_app/webdriver_test/web_compiler_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,52 +14,76 @@ import 'package:webdriver/async_io.dart';
import '../integration_test/test_infra/run/run_test.dart';

void main() {
late Process devtoolsProcess;
late WebDriver driver;
ChromeDriver? chromedriver;
Process? devtoolsProcess;
WebDriver? driver;
late String devToolsServerAddress;

const serverStartupTimeout = Duration(minutes: 1);

Future<void> cleanUp() async {
try {
await driver?.quit();
} finally {
driver = null;
devtoolsProcess?.kill();
devtoolsProcess = null;
await chromedriver?.stop(debugLogging: true);
chromedriver = null;
}
}
Comment thread
srawlins marked this conversation as resolved.
Resolved

setUpAll(() async {
await ChromeDriver().start(debugLogging: true);

// TODO(https://github.com/flutter/devtools/issues/9197): Launch the
// DevTools server from source.
// For now, this test uses the version of DevTools bundled in the Dart SDK
// because building and running from source is too prohibitive until
// DevTools is moved into the Dart SDK. See issue for details.
devtoolsProcess = await startDevToolsServer();
devToolsServerAddress = await listenForDevToolsAddress(
devtoolsProcess,
timeout: serverStartupTimeout,
);

driver = await createDriver(
uri: Uri.parse('http://127.0.0.1:${ChromeDriver.port}'),
desired: {
...Capabilities.chrome,
Capabilities.chromeOptions: {
'binary': ?Platform.environment['CHROME_EXECUTABLE'],
'args': [
'--headless',
// Explicitly enable SwiftShader on headless Linux and Windows VMs
// without a hardware GPU so WebGL is available for the skwasm
// renderer. See https://github.com/flutter/devtools/issues/10032.
if (Platform.isLinux || Platform.isWindows) ...[
'--use-gl=angle',
'--use-angle=swiftshader',
'--enable-unsafe-swiftshader',
'--disable-gpu-sandbox',
try {
chromedriver = ChromeDriver();
await chromedriver!.start(debugLogging: true);
Comment thread
srawlins marked this conversation as resolved.
Resolved

// TODO(https://github.com/flutter/devtools/issues/9197): Launch the
// DevTools server from source.
// For now, this test uses the version of DevTools bundled in the Dart SDK
// because building and running from source is too prohibitive until
// DevTools is moved into the Dart SDK. See issue for details.
final startedDevToolsProcess = await startDevToolsServer();
devtoolsProcess = startedDevToolsProcess;
devToolsServerAddress = await listenForDevToolsAddress(
startedDevToolsProcess,
timeout: serverStartupTimeout,
);

driver = await createDriver(
uri: Uri.parse('http://127.0.0.1:${ChromeDriver.port}'),
desired: {
...Capabilities.chrome,
Capabilities.chromeOptions: {
'binary': ?Platform.environment['CHROME_EXECUTABLE'],
Comment thread
srawlins marked this conversation as resolved.
Resolved
'args': [
'--headless',
// Apparently, on Ubuntu 24.04+, AppArmor restricts unprivileged user
// namespaces, so this Chrome must be run with '--no-sandbox'.
// Flutter's `ChromiumLauncher.launch` similarly adds '--no-sandbox'
// when headless.
if (Platform.isLinux) '--no-sandbox',
// Explicitly enable SwiftShader on headless Linux and Windows VMs
// without a hardware GPU so WebGL is available for the skwasm
// renderer. See https://github.com/flutter/devtools/issues/10032.
if (Platform.isLinux || Platform.isWindows) ...[
'--use-gl=angle',
'--use-angle=swiftshader',
'--enable-unsafe-swiftshader',
'--disable-gpu-sandbox',
],
],
],
},
},
},
);
);
} catch (_) {
await cleanUp();
rethrow;
}
});

tearDownAll(() async {
await driver.quit();
devtoolsProcess.kill();
await cleanUp();
});

/// Reads the "flt-renderer" attribute on the body element.
Expand All @@ -68,7 +92,7 @@ void main() {
/// https://github.com/flutter/devtools/pull/9406#pullrequestreview-3142210823
Future<String?> readRendererAttribute() => retryAsync<String?>(
() async {
final body = await driver.findElement(const By.tagName('body'));
final body = await driver!.findElement(const By.tagName('body'));
return body.attributes['flt-renderer'];
},
condition: (result) => result != null,
Expand All @@ -80,15 +104,15 @@ void main() {
timeout: longTimeout,
() async {
// Open the DevTools URL with ?compiler=wasm.
await driver.get(
await driver!.get(
_addQueryParam(devToolsServerAddress, param: 'compiler', value: 'wasm'),
);

// Verify we are using the skwasm renderer.
expect(await readRendererAttribute(), equals('skwasm'));

// Open the DevTools URL with ?compiler=js.
await driver.get(
await driver!.get(
_addQueryParam(devToolsServerAddress, param: 'compiler', value: 'js'),
);

Expand Down
Loading