Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the setup and teardown logic in web_compiler_test.dart to introduce a robust cleanUp helper and ensure resources are properly released if setup fails. It also adds the --no-sandbox flag for headless Linux environments. Feedback highlights a critical compilation error due to invalid Dart syntax (? prefix) when checking the CHROME_EXECUTABLE environment variable. Additionally, improvements are suggested to prevent exception masking during cleanup and to avoid using the null-assertion operator on chromedriver.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was found while trying to enable some web tests on Linux on LUCI.
Linux web tests failed on LUCI, see the log. Apparently this is because on Ubuntu 24.04+ w/ AppArmor, we need to pass
--no-sandbox.Additionally this cleans up lifecycle/retry handling: save the ChromeDriver instance and call
await chromedriver?.stop()(right now it is never stopped even on success, so retry: 3 retries all hitbind() failed: Address already in use (98)on port 4444), and makedriver/devtoolsProcessnullable sotearDownAlldoesn't throwLateInitializationErrorand leak processes whensetUpAllfails.