Skip to content

Backport(v1.19): output: treat JSON::GeneratorError as unrecoverable error (#5419) #5423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Watson1978 merged 1 commit into from
Jul 13, 2026
+5 −2
Merged

Backport(v1.19): output: treat JSON::GeneratorError as unrecoverable error (#5419) #5423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/fluent/plugin/output.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
require 'fluent/clock'
require 'fluent/ext_monitor_require'

require 'json'
require 'time'

module Fluent
Expand Down Expand Up @@ -1212,7 +1213,7 @@ def next_flush_time
end
end

UNRECOVERABLE_ERRORS = [Fluent::UnrecoverableError, TypeError, ArgumentError, NoMethodError, MessagePack::UnpackError, EncodingError]
UNRECOVERABLE_ERRORS = [Fluent::UnrecoverableError, TypeError, ArgumentError, NoMethodError, MessagePack::UnpackError, EncodingError, JSON::GeneratorError]

def try_flush
chunk = @buffer.dequeue_chunk
Expand Down
4 changes: 3 additions & 1 deletion test/plugin/test_output_as_buffered_backup.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ def wait_flush(target_file)
'argument error' => ArgumentError,
'no method error' => NoMethodError,
'msgpack unpack error' => MessagePack::UnpackError,
'encoding error' => EncodingError)
'encoding error' => EncodingError,
'json generate error' => JSON::GeneratorError
)
test 'backup chunk without secondary' do |error_class|
Fluent::SystemConfig.overwrite_system_config('root_dir' => TMP_DIR) do
id = 'backup_test'
Expand Down
Loading