Backport(v1.19): output: treat JSON::GeneratorError as unrecoverable error (#5419)#5423
Open
github-actions[bot] wants to merge 1 commit into
Open
Backport(v1.19): output: treat JSON::GeneratorError as unrecoverable error (#5419)#5423github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
**Which issue(s) this PR fixes**: Fixes #5414 **What this PR does / why we need it**: When JSON generation fails for content reasons (e.g. non-UTF-8 bytes, NaN/Infinity), `JSON.generate` raises `JSON::GeneratorError`. This is deterministic for a given chunk, so retrying can never succeed and the chunk should be treated as a bad chunk. **Docs Changes**: N/A **Release Note**: * output: treat JSON::GeneratorError as unrecoverable error Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Backport #5419
Fixes #5414
What this PR does / why we need it:
When JSON generation fails for content reasons (e.g. non-UTF-8 bytes, NaN/Infinity),
JSON.generateraisesJSON::GeneratorError.This is deterministic for a given chunk, so retrying can never succeed and the chunk should be treated as a bad chunk.
Docs Changes:
N/A
Release Note: