Skip to content

docs: outputs: azure_logs_ingestion: fix defaults, sort table, update key casing#2413

Merged
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics-out-azure-log-ingestion-updates
Mar 12, 2026
Merged

docs: outputs: azure_logs_ingestion: fix defaults, sort table, update key casing#2413
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics-out-azure-log-ingestion-updates

Conversation

@eschabell
Copy link
Collaborator

@eschabell eschabell commented Mar 11, 2026

  • Fix compress default: true -> false (source-verified)
  • Fix time_generated default: true -> false (source-verified)
  • Sort configuration parameters table alphabetically
  • Fix missing space: Data Collection Endpoint(DCE) -> Data Collection Endpoint (DCE)
  • Add missing trailing period to table_name description
  • Classic config: use Title_Case for all plugin-specific keys

Applies to #2412

Summary by CodeRabbit

  • Documentation
    • Updated Azure logs ingestion configuration documentation with new parameters: compress and time_generated.
    • Improved configuration examples and parameter formatting for clarity.

… key casing

  - Fix `compress` default: `true` -> `false` (source-verified)
  - Fix `time_generated` default: `true` -> `false` (source-verified)
  - Sort configuration parameters table alphabetically
  - Fix missing space: `Data Collection Endpoint(DCE)` -> `Data Collection Endpoint (DCE)`
  - Add missing trailing period to `table_name` description
  - Classic config: use Title_Case for all plugin-specific keys

Applies to fluent#2412

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Mar 11, 2026
@eschabell eschabell requested a review from a team as a code owner March 11, 2026 13:27
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0 labels Mar 11, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9cc09988-557b-4729-9b1b-346f5cd77099

📥 Commits

Reviewing files that changed from the base of the PR and between 1481ad4 and 2e95307.

📒 Files selected for processing (1)
  • pipeline/outputs/azure_logs_ingestion.md

📝 Walkthrough

Walkthrough

This pull request updates documentation for the Azure Logs Ingestion output plugin, introducing new configuration parameters (compress and time_generated) and standardizing parameter naming conventions from snake_case to CamelCase format throughout configuration tables and code examples.

Changes

Cohort / File(s) Summary
Documentation Updates
pipeline/outputs/azure_logs_ingestion.md
Added new configuration keys (compress and time_generated), converted parameter labels to CamelCase format (Client_Id, Client_Secret, Tenant_Id, Dce_Url, Dcr_Id, Table_Name, Time_Generated, Time_Key), updated configuration examples and snippets to reflect new naming and parameter defaults.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 With CamelCase now standing tall,
And azure params answering the call,
Our docs shine bright, so crisp and clean—
The finest docs you've ever seen! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the main documentation changes: fixing default values, sorting the configuration table, and updating parameter key casing from snake_case to CamelCase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Collaborator Author

@cosmo0920 and @patrick-stephens ready for review!

@eschabell eschabell merged commit df1b692 into fluent:master Mar 12, 2026
8 checks passed
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Mar 12, 2026
@eschabell eschabell deleted the erics-out-azure-log-ingestion-updates branch March 12, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants