outputs: azure_logs_ingestion: Update time_generated description#2411
outputs: azure_logs_ingestion: Update time_generated description#2411hashtagchris wants to merge 1 commit intofluent:masterfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated documentation for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/azure_logs_ingestion.md`:
- Line 35: Update the `time_generated` description to clarify the floating-point
representation: state that when disabled the timestamp is a floating‑point
number representing seconds since the Unix epoch (i.e., Unix time as fractional
seconds), and ensure the wording references `time_key` so it reads: "If
disabled, it is a floating-point number of seconds since the Unix epoch." This
aligns the `time_generated` explanation with other plugin docs (GELF, Plot) and
removes ambiguity about the reference point.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f739d277-ee95-4aa1-a860-810c159ec0b2
📒 Files selected for processing (1)
pipeline/outputs/azure_logs_ingestion.md
084153e to
8d3d1f5
Compare
|
@hashtagchris thanks for the docs PR, as you can see need to fix the lint errors: I'll review once all errors are addressed. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/azure_logs_ingestion.md`:
- Line 35: The sentence describing `time_generated` uses the contraction "it's";
update the Markdown to expand the contraction to "it is" so the line reads
"...If disabled, it is a floating-point number representing seconds since Unix
epoch." Locate the table row referencing `time_generated` and `time_key` and
replace "it's" with "it is" to satisfy the Vale lint rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 031c5df6-84d2-47cf-9cc6-23a56f4077e3
📒 Files selected for processing (1)
pipeline/outputs/azure_logs_ingestion.md
| | `table_name` | The name of the custom log table (include the `_CL` suffix as well if applicable) | _none_ | | ||
| | `time_key` | Optional. Specify the key name where the timestamp will be stored. | `@timestamp` | | ||
| | `time_generated` | Optional. If enabled, will generate a timestamp and append it to JSON. The key name is set by the `time_key` parameter. | `true` | | ||
| | `time_generated` | Optional. If enabled, the timestamp appended under `time_key` is formatted as an ISO 8601 string. If disabled, it's a floating-point number representing seconds since Unix epoch. | `true` | |
There was a problem hiding this comment.
Fix the contraction to resolve Vale lint error.
The Vale linter flagged the contraction "it's" on this line. Technical documentation should avoid contractions for formality and clarity.
📝 Proposed fix to expand the contraction
-| `time_generated` | Optional. If enabled, the timestamp appended under `time_key` is formatted as an ISO 8601 string. If disabled, it's a floating-point number representing seconds since Unix epoch. | `true` |
+| `time_generated` | Optional. If enabled, the timestamp appended under `time_key` is formatted as an ISO 8601 string. If disabled, it is a floating-point number representing seconds since Unix epoch. | `true` |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | `time_generated` | Optional. If enabled, the timestamp appended under `time_key` is formatted as an ISO 8601 string. If disabled, it's a floating-point number representing seconds since Unix epoch. | `true` | | |
| | `time_generated` | Optional. If enabled, the timestamp appended under `time_key` is formatted as an ISO 8601 string. If disabled, it is a floating-point number representing seconds since Unix epoch. | `true` | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pipeline/outputs/azure_logs_ingestion.md` at line 35, The sentence describing
`time_generated` uses the contraction "it's"; update the Markdown to expand the
contraction to "it is" so the line reads "...If disabled, it is a floating-point
number representing seconds since Unix epoch." Locate the table row referencing
`time_generated` and `time_key` and replace "it's" with "it is" to satisfy the
Vale lint rule.
|
@hashtagchris sorry my friend, but there is now conflicts due to ongoing updates that hit this plugin doc as we prep for coming release. Can you rebase to pull the changes into your branch, should solve it. |
`time_generated` influences the time format, not the addition of the time field. See https://github.com/fluent/fluent-bit/blob/a1d9c2a9a637bba1d8918c6c7a49b8279fd6df0a/plugins/out_azure_logs_ingestion/azure_logs_ingestion.c#L107-L131 Signed-off-by: Chris Sidi <hashtagchris@github.com>
|
@eschabell Rebased. Thanks for the speedy review, and all you do to keep the docs high-quality! |
The
time_generatedconfig setting influences the time format, not the addition of a timestamp field as previously documented.Reference: https://github.com/fluent/fluent-bit/blob/a1d9c2a9a637bba1d8918c6c7a49b8279fd6df0a/plugins/out_azure_logs_ingestion/azure_logs_ingestion.c#L107-L131
Summary by CodeRabbit