out_azure_logs_ingestion: increase timestamp precision to 100ns#11534
out_azure_logs_ingestion: increase timestamp precision to 100ns#11534hashtagchris wants to merge 1 commit intofluent:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughISO 8601 fractional-second precision in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
989e857 to
a01d4e9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/out_azure_logs_ingestion/azure_logs_ingestion.c`:
- Around line 422-426: The config help text for time_generated is inconsistent
with the actual emitted value: verify what unit flb_time_to_double(&tm) returns,
and then either (A) restore the doc string to say "seconds" (reword the disabled
branch text in the help string for struct flb_az_li/time_generated to "a
floating-point number of seconds") if flb_time_to_double returns seconds, or (B)
change the serialization path that uses flb_time_to_double(&tm) to emit
milliseconds (multiply the returned value by 1000 or use an appropriate helper)
and keep the help text saying "milliseconds"; update references to
time_key/time_generated accordingly so the doc string and emitted value match.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9fdf6c91-66e9-4a90-9c1e-d2f8cfb4f326
📒 Files selected for processing (1)
plugins/out_azure_logs_ingestion/azure_logs_ingestion.c
a01d4e9 to
43c760b
Compare
43c760b to
7c81398
Compare
Increase the ISO 8601 timestamp precision from milliseconds (3 decimal digits) to 100 nanoseconds (7 decimal digits). The flb_time struct already stores nanosecond-precision timestamps via tv_nsec. This change preserves that precision in the formatted output instead of truncating to milliseconds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Chris Sidi <hashtagchris@github.com>
7c81398 to
27f03bf
Compare
|
@coderabbitai resume |
✅ Actions performedReviews resumed. |

Summary
Increase the ISO 8601 timestamp precision in the
azure_log_ingestionoutput plugin from milliseconds (3 decimal digits) to 100 nanoseconds (7 decimal digits).Before:
2026-03-11T00:10:36.123ZAfter:
2026-03-11T00:10:36.1234567ZDetails
The
flb_timestruct already stores nanosecond-precision timestamps viatv_nsec. This change preserves that precision in the formatted output instead of truncating to milliseconds.Changes
%03→%07(7 zero-padded digits)/ 1000000→/ 100(100-nanosecond granularity)Also updates the
time_generatedconfig description to accurately reflect that it controls the timestamp format (ISO 8601 vs floating-point), not whether a timestamp is appended. Doc PR: fluent/fluent-bit-docs#2411The
time_formattedbuffer (32 bytes) has sufficient capacity for the longer output (29 bytes max including null terminator).Reference
"Time values are measured in 100-nanosecond units called ticks..." - https://learn.microsoft.com/en-us/kusto/query/scalar-data-types/datetime
Summary by CodeRabbit
Bug Fixes
Configuration / Behavior