Skip to content

Adjust version checking logging levels to debug #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
firstof9 merged 1 commit into from
May 21, 2026
+8 −8
Merged

Adjust version checking logging levels to debug #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions openevsehttp/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ def _version_check(self, min_version: str, max_version: str = "") -> bool:
"""Return bool if minimum version is met."""
if "version" not in self._config:
# Throw warning if we can't find the version
_LOGGER.warning("Unable to find firmware version.")
_LOGGER.debug("Unable to find firmware version.")
return False
cutoff = AwesomeVersion(min_version)
limit = ""
Expand All @@ -447,10 +447,10 @@ def _version_check(self, min_version: str, max_version: str = "") -> bool:

current = get_awesome_version(self._config["version"])
if current.strategy == "unknown":
_LOGGER.warning(
"Non-standard versioning string: %s", self._config["version"]
_LOGGER.debug(
"Non-semver firmware version detected: %s",
self._config["version"],
)
_LOGGER.debug("Non-semver firmware version detected.")
return False

if limit:
Expand Down
4 changes: 2 additions & 2 deletions openevsehttp/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ async def firmware_check(self) -> dict | None:
"""Return the latest firmware version."""
if "version" not in self._config:
# Throw warning if we can't find the version
_LOGGER.warning("Unable to find firmware version.")
_LOGGER.debug("Unable to find firmware version.")
return None
base_url = "https://api.github.com/repos/OpenEVSE/"
url = None
Expand All @@ -376,7 +376,7 @@ async def firmware_check(self) -> dict | None:
else:
url = f"{base_url}ESP8266_WiFi_v2.x/releases/latest"
except AwesomeVersionCompareException:
_LOGGER.warning("Non-semver firmware version detected.")
_LOGGER.debug("Non-semver firmware version detected.")
return None

try:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ async def test_firmware_check(
with caplog.at_level(logging.DEBUG):
firmware = await test_charger_unknown_semver.firmware_check()
assert "Using version: random_a4f11e" in caplog.text
assert "Non-semver firmware version detected." in caplog.text
assert "Non-semver firmware version detected" in caplog.text
assert firmware is None


Expand Down
2 changes: 1 addition & 1 deletion tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ async def test_set_divertmode(
with pytest.raises(UnsupportedFeature):
with caplog.at_level(logging.DEBUG):
await test_charger_unknown_semver.divert_mode()
assert "Non-semver firmware version detected." in caplog.text
assert "Non-semver firmware version detected" in caplog.text


async def test_set_divertmode_dict(test_charger_new, mock_aioclient):
Expand Down
Loading