Skip to content

Adjust version checking logging levels to debug#574

Merged
firstof9 merged 1 commit into
mainfrom
logging-level-adjustments
May 21, 2026
Merged

Adjust version checking logging levels to debug#574
firstof9 merged 1 commit into
mainfrom
logging-level-adjustments

Conversation

@firstof9
Copy link
Copy Markdown
Owner

@firstof9 firstof9 commented May 21, 2026

This PR updates version-checking and firmware parsing log messages from WARNING to DEBUG level.

Changes

  • openevsehttp/client.py:
    • Changes "Unable to find firmware version." from warning to debug.
    • Consolidates non-semver checking logs into a single debug log message: "Non-semver firmware version detected: %s".
  • openevsehttp/commands.py:
    • Changes "Unable to find firmware version." from warning to debug.
    • Changes "Non-semver firmware version detected." under AwesomeVersionCompareException from warning to debug.
  • tests/:
    • Updates existing test assertions in test_client.py and test_commands.py to match the updated debug log string (without the trailing dot).

These changes eliminate verbose log spamming on integration startup or when utilizing custom firmware versions.

Summary by CodeRabbit

  • Chores
    • Refined logging behavior for firmware version checks. Detection of missing or non-standard firmware versions now logs at debug level instead of warning level. This reduces non-critical warning messages in standard logs while preserving comprehensive diagnostic information in debug output for advanced troubleshooting.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1dc327a2-d37e-44a9-9e49-bf37b35b573f

📥 Commits

Reviewing files that changed from the base of the PR and between 520c0e8 and 58957ae.

📒 Files selected for processing (4)
  • openevsehttp/client.py
  • openevsehttp/commands.py
  • tests/test_client.py
  • tests/test_commands.py

📝 Walkthrough

Walkthrough

Firmware version check errors are downgraded from warning to debug level in both the client library and command mixin. Non-semver version detection now logs only at debug level with enhanced detail. Test assertions are updated to match the new message formats.

Changes

Firmware Version Checking Log Level Reduction

Layer / File(s) Summary
Client and command mixin firmware checks
openevsehttp/client.py, openevsehttp/commands.py
Missing firmware version and non-semver version detection logging is reduced from warning to debug level in OpenEVSE._version_check and CommandsMixin.firmware_check. Client-side non-semver handling replaces warning-plus-debug messaging with multi-line debug output showing the detected version.
Test assertion updates
tests/test_client.py, tests/test_commands.py
Test expectations for firmware version logging are updated to match the exact new message text by removing trailing periods from the assertion strings.

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly Related PRs

  • firstof9/python-openevse-http#575: Refactors firmware version parsing in the same methods (OpenEVSE._version_check and CommandsMixin.firmware_check), making this PR's log-level adjustments and test updates directly connected to that parsing refactor.

Poem

🐰 Firmware logs now whisper softly,
Where warnings once did shout—
Debug-level hush for missing versions,
Non-semver versions spelled out.
Tests aligned in harmony,
A quieter path throughout! 🔍

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Adjust version checking logging levels to debug' directly and accurately summarizes the main change: reducing firmware/version checking log levels from WARNING to DEBUG across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch logging-level-adjustments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@firstof9
Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@firstof9 firstof9 force-pushed the logging-level-adjustments branch from 057ada9 to 58957ae Compare May 21, 2026 02:11
@firstof9
Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@firstof9 firstof9 merged commit 3aa92c7 into main May 21, 2026
11 checks passed
@firstof9 firstof9 deleted the logging-level-adjustments branch May 21, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant