Skip to content

chore: Remove Python < 3.7 timezone workaround #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lahirumaramba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Remove Python < 3.7 timezone workaround #938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions firebase_admin/_rfc3339.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ def _parse_to_datetime(datestr):
except ValueError:
pass

# Note: %z parses timezone offsets, but requires the timezone offset *not*
# include a separating ':'. As of python 3.7, this was relaxed.
# TODO(rsgowman): Once python3.7 becomes our floor, we can drop the regex
# replacement.
datestr_modified = re.sub(r'(\d\d):(\d\d)$', r'\1\2', datestr_modified)

try:
return datetime.strptime(datestr_modified, '%Y-%m-%dT%H:%M:%S.%f%z')
except ValueError:
Expand Down
Loading