Skip to content

Comments

chore: Remove Python < 3.7 timezone workaround#938

Open
lahirumaramba wants to merge 1 commit intomainfrom
remove-tz-workaround-16812131302258433956
Open

chore: Remove Python < 3.7 timezone workaround#938
lahirumaramba wants to merge 1 commit intomainfrom
remove-tz-workaround-16812131302258433956

Conversation

@lahirumaramba
Copy link
Member

Removed the regex substitution and associated comments that were used as a workaround for parsing timezone offsets with colons in older Python versions. verified that RFC3339 parsing still works correctly with and without colons in timezone offsets.


PR created automatically by Jules for task 16812131302258433956 started by @lahirumaramba

Python 3.7+ supports %z with colons in timezone offsets. Since this
project now requires Python >= 3.9, the regex substitution to remove
colons from timezone offsets is no longer necessary and can be removed.

Co-authored-by: lahirumaramba <55609+lahirumaramba@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Feb 20, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the RFC3339 date-time parsing logic by removing a legacy workaround. The change leverages improvements in Python 3.7 and later, which natively support parsing timezone offsets containing colons, thereby simplifying the codebase and removing technical debt.

Highlights

  • Timezone Parsing Workaround Removed: Eliminated a regex substitution and associated comments previously used to handle timezone offsets with colons in Python versions older than 3.7, simplifying the _parse_to_datetime function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • firebase_admin/_rfc3339.py
    • Removed a regex substitution that stripped colons from timezone offsets.
    • Deleted comments explaining the necessity of the workaround for Python versions prior to 3.7.
Activity
  • PR created automatically by Jules for task 16812131302258433956, initiated by @lahirumaramba.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lahirumaramba lahirumaramba changed the title Remove Python < 3.7 timezone workaround chore: Remove Python < 3.7 timezone workaround Feb 20, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a workaround for parsing RFC3339 date strings on Python versions older than 3.7. The change is a simple deletion of obsolete code, which correctly relies on the improved datetime.strptime functionality in modern Python versions. This improves code clarity and maintainability. The change is correct and I have no suggestions for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant