-
Notifications
You must be signed in to change notification settings - Fork 9
♻️ Let backend handle new lines #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import re | ||
|
|
||
| from rich.ansi import AnsiDecoder | ||
| from rich.text import Text | ||
|
|
||
| ANSI_NEWLINE_SPLIT_RE = re.compile(r"(?<=\n)") | ||
|
|
||
|
|
||
| def text_from_ansi(text: str) -> Text: | ||
| # Text.from_ansi only preserves newlines in Rich 15, in order to | ||
| # avoid forcing everyone to use Rich 15 we handle this ourselves by splitting the text on newlines, | ||
| # decoding each line separately, then join them back together with newlines. | ||
| joiner = Text("\n") | ||
| decoder = AnsiDecoder() | ||
|
|
||
| return joiner.join( | ||
| decoder.decode_line(line.rstrip("\n")) | ||
| for line in ANSI_NEWLINE_SPLIT_RE.split(text) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| from fastapi_cloud_cli.utils.rich_ansi import text_from_ansi | ||
|
|
||
|
|
||
| def test_text_from_ansi_preserves_newlines() -> None: | ||
| assert text_from_ansi("").plain == "" | ||
| assert text_from_ansi("\n").plain == "\n" | ||
| assert text_from_ansi("\n\n").plain == "\n\n" | ||
| assert text_from_ansi("Hello").plain == "Hello" | ||
| assert text_from_ansi("Hello\n").plain == "Hello\n" | ||
| assert text_from_ansi("Hello\n\n").plain == "Hello\n\n" | ||
| assert text_from_ansi("Hello\n World").plain == "Hello\n World" | ||
| assert text_from_ansi("Hello\n\n World").plain == "Hello\n\n World" | ||
| assert text_from_ansi("Hello\n World\n").plain == "Hello\n World\n" | ||
|
|
||
|
|
||
| def test_text_from_ansi_handles_carriage_returns_per_line() -> None: | ||
| assert text_from_ansi("start\rend").plain == "end" | ||
| assert text_from_ansi("start\rend\n").plain == "end\n" | ||
| assert text_from_ansi("one\rtwo\nthree").plain == "two\nthree" | ||
| assert text_from_ansi("one\ntwo\rthree\n").plain == "one\nthree\n" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rich's Text.from_ansi in 14 strips new lines, in version 15 it is fine, but I don't to force either version, so we have our own tiny function that handles the newlines as we expect