♻️ Let backend handle new lines#196
Closed
patrick91 wants to merge 2 commits into
Closed
Conversation
Shortcake-Parent: main
patrick91
commented
May 13, 2026
|
|
||
| if log.type == "message": | ||
| progress.log(Text.from_ansi(log.message.rstrip())) # ty: ignore[unresolved-attribute] | ||
| progress.log(text_from_ansi(log.message)) # ty: ignore[unresolved-attribute] |
Collaborator
Author
There was a problem hiding this comment.
Rich's Text.from_ansi in 14 strips new lines, in version 15 it is fine, but I don't to force either version, so we have our own tiny function that handles the newlines as we expect
Collaborator
Author
|
Might avoid this for the time being 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
let-backend-handle-new-lines) <-- this PR