Skip to content

[6/n][sl][github][gh stacks] wire up gh stacks to sl pull - #1397

Open
raydatray wants to merge 6 commits into
facebook:mainfrom
raydatray:pr1397
Open

[6/n][sl][github][gh stacks] wire up gh stacks to sl pull#1397
raydatray wants to merge 6 commits into
facebook:mainfrom
raydatray:pr1397

Conversation

@raydatray

@raydatray raydatray commented Jul 31, 2026

Copy link
Copy Markdown

ctx

sl pr pull links a diff's ancestors by parsing the sapling stack list footer, which the stacked workflow omits in #1395

changes made

  • when the body has no footer, query the native stacks API and link the ancestors below the diff from the stack instead
  • warns only if the diff is in no stack at all

test plan

  • next test-ext-github-pr-pull-stacked.t with mocked stack responses
  • dogfooded on my own computer
sl config --local extensions.github=/Users/ray/sapling/eden/scm/sapling/ext/github/__init__.py
sl config --local extensions.signing_shim=/Users/ray/.sl-signing-shim.py
sl config --local github.pr-workflow=stacked
Screenshot 2026-07-31 at 3 49 38 PM
  • go back to local and run sl pull - we see what those two are marked as landed
Screenshot 2026-07-31 at 3 50 14 PM
  • rebase those two remaining diffs on main, and then resubmit, we see that the stack remains preserved on github
Screenshot 2026-07-31 at 3 51 26 PM

Stack created with Sapling. Best reviewed with ReviewStack.

@meta-codesync

meta-codesync Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D114402759. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant