[1/n][sl][github][gh stacks] support headers and list params - #1392
Open
raydatray wants to merge 1 commit into
Open
[1/n][sl][github][gh stacks] support headers and list params#1392raydatray wants to merge 1 commit into
raydatray wants to merge 1 commit into
Conversation
Summary: Test Plan:
This was referenced Jul 31, 2026
|
This pull request has been imported. If you are a Meta employee, you can view this in D114402510. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctx
github added native stacked pull requests, it would be nice to add native support to it for sapling!
this stack lets
sl pr submitandsl pullvia a newgithub.pr.workflow = stackedmodechanges made
github_gh_cli.make_requestaccepts custom headers (-H, needed for theX-GitHub-Api-Versionpreview header)_format_paramsupports list values using thegh apirepeated-field syntax (pull_requests[]=101)test plan
doctests in
_format_param(registered in test-doctest.py), existing github .t suiteStack created with Sapling. Best reviewed with ReviewStack.