Skip to content

[1/n][sl][github][gh stacks] support headers and list params - #1392

Open
raydatray wants to merge 1 commit into
facebook:mainfrom
raydatray:pr1392
Open

[1/n][sl][github][gh stacks] support headers and list params#1392
raydatray wants to merge 1 commit into
facebook:mainfrom
raydatray:pr1392

Conversation

@raydatray

@raydatray raydatray commented Jul 31, 2026

Copy link
Copy Markdown

ctx

github added native stacked pull requests, it would be nice to add native support to it for sapling!

this stack lets sl pr submit and sl pull via a new github.pr.workflow = stacked mode

changes made

  • github_gh_cli.make_request accepts custom headers (-H, needed for the X-GitHub-Api-Version preview header)
  • _format_param supports list values using the gh api repeated-field syntax (pull_requests[]=101)
  • mock_utils updated to match

test plan

doctests in _format_param (registered in test-doctest.py), existing github .t suite


Stack created with Sapling. Best reviewed with ReviewStack.

@meta-codesync

meta-codesync Bot commented Jul 31, 2026

Copy link
Copy Markdown

This pull request has been imported. If you are a Meta employee, you can view this in D114402510. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant