Skip to content

Remove the ninja build-from-source#1742

Open
sbc100 wants to merge 1 commit into
mainfrom
remove_ninja_build_from_source
Open

Remove the ninja build-from-source#1742
sbc100 wants to merge 1 commit into
mainfrom
remove_ninja_build_from_source

Conversation

@sbc100

@sbc100 sbc100 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Now that we have ninja binaries available for install (See #1105), I don't think we need to be able to build it from source anymore.

We can treat ninja more like node and/or python and just depend on the binary version of it.

Also, add missing arm64 binaries for ninja for windows and linux

@sbc100
sbc100 requested a review from juj July 21, 2026 16:25
Now that we have ninja binaries available for install (See #1105),
I don't think we need to be able to build it from source anymore.

We can treat ninja more like node and/or python and just depend
on the binary version of it.
@sbc100
sbc100 force-pushed the remove_ninja_build_from_source branch from 651ed7a to 6979cba Compare July 21, 2026 16:28
@sbc100
sbc100 requested a review from dschuff July 21, 2026 16:29
@dschuff

dschuff commented Jul 21, 2026

Copy link
Copy Markdown
Member

If @juj wants the build-from-source for the compilers to allow code signing and such, and if we are going to start depending on Ninja for building libraries, then he might want to keep the ninja build-from-source for the same reasons.

@sbc100

sbc100 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

If @juj wants the build-from-source for the compilers to allow code signing and such, and if we are going to start depending on Ninja for building libraries, then he might want to keep the ninja build-from-source for the same reasons.

I doubt the official ninja binaries are are problem though, right?

Also, even in a Ninja build its still Visual Studio (the official MS binaries) that are doing all the compiling and linking. The version of ninja.exe used to invoke the tools I don't think plays any role in the resulting signature/binary right?

@dschuff

dschuff commented Jul 21, 2026

Copy link
Copy Markdown
Member

I doubt the official ninja binaries are are problem though, right?

🤷 Dunno. Are they signed?

Also, even in a Ninja build its still Visual Studio (the official MS binaries) that are doing all the compiling and linking. The version of ninja.exe used to invoke the tools I don't think plays any role in the resulting signature/binary right?

Yeah, mostly I think the issue is that they don't want to ship any binaries to run on the users' machine that aren't signed, since they may be blocked by the OS. So if they are packaging all possible target libraries ahead of time, then it's not an issue. But if some libraries get built on demand, the ninja binary would need to be signed by someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants