Conversation
Member
|
this looks fine, although we probably don't need to land it until/unless we decide to take the dependence for external developers |
We may start using it internally in emscripten. See emscripten-core/emscripten#17809
juj
reviewed
Jun 2, 2026
| "id": "ninja", | ||
| "version": "1.11.1", | ||
| "bitness": 64, | ||
| "windows_url": "ninja-1.11.1-win.zip", |
Collaborator
There was a problem hiding this comment.
The artifact would be good to be named x64 here. (I presume the Windows artifact is x64 and not arm64). Does this work with arm64? Can we bundle a separate windows arm64 version?
juj
reviewed
Jun 2, 2026
| "bitness": 64, | ||
| "windows_url": "ninja-1.11.1-win.zip", | ||
| "linux_url": "ninja-1.11.1-linux.zip", | ||
| "macos_url": "ninja-1.11.1-mac.zip", |
Collaborator
There was a problem hiding this comment.
Likewise here for Linux x64 vs arm64, and mac x64 vs arm64?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may start using it internally in emscripten. See emscripten-core/emscripten#17809