Skip to content

Don't build libopenmp in wasm64 mode #27692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschuff merged 2 commits into from
Sep 9, 2026
+5 −0
Merged

Don't build libopenmp in wasm64 mode #27692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
143cfc5
Don't build libopenmp in wasm64 mode
dschuff Sep 9, 2026
cf1671f
add link
dschuff Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/system_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2328,6 +2328,11 @@ class libopenmp(Library):
'kmp_ftn_extra.cpp', 'kmp_version.cpp', 'z_Linux_asm.S',
]

def can_build(self):
# OpenMP currently doesn't support Wasm64, see
# https://github.com/emscripten-core/emscripten/issues/27221
return super().can_build() and not settings.MEMORY64

@kripken kripken Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue or something we can link to? Or if not, a comment like "is not currently supported" might make sense (assuming it might be supported some day)

@dschuff dschuff Sep 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, it's #27221



def get_libs_to_link():
libs_to_link = []
Expand Down
Loading