Don't build libopenmp in wasm64 mode - #27692
Merged
Merged
Conversation
The library doesn't support wasm64 and will error out. This causes ./embuilder --wasm64 build SYSTEM to fail.
kripken
approved these changes
Sep 9, 2026
| ] | ||
|
|
||
| def can_build(self): | ||
| return super().can_build() and not settings.MEMORY64 |
Member
There was a problem hiding this comment.
Is there an issue or something we can link to? Or if not, a comment like "is not currently supported" might make sense (assuming it might be supported some day)
dschuff
enabled auto-merge (squash)
September 9, 2026 22:12
kripken
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library doesn't support wasm64 and will error out. This causes
./embuilder --wasm64 build SYSTEMto fail.
See #27221