fix(engine): handle matches against any struct#343
Merged
doorgan merged 1 commit intoelixir-lang:mainfrom Jan 28, 2026
Merged
Conversation
doorgan
approved these changes
Jan 28, 2026
Collaborator
doorgan
left a comment
doorgan
left a comment
There was a problem hiding this comment.
Thanks! It works
Let's just assert rather than crashing the test in the ones I commented and it's good to merge
apps/engine/test/engine/search/indexer/extractors/struct_reference_test.exs
Outdated
Show resolved
Hide resolved
apps/engine/test/engine/search/indexer/extractors/struct_reference_test.exs
Outdated
Show resolved
Hide resolved
katafrakt
force-pushed
the
any-struct-pattern-match
branch
from
27ea1b0 to
6085028
Compare
doorgan
pushed a commit
that referenced
this pull request
Feb 2, 2026
I noticed that after upgrading to the current newest version ([375391c](375391c)) I still see a lot of the following log ``` Could not expand alias: {:mod, [], MyModule} ``` The should be resolved after #343, but there is a small typo in one of the heads of `expand_alias(ast_node, reducer)`. I've hopefully fixed the issue for good by pattern matching against the AST representation of a variable in the appropriate head clause and adding tests for the log. I've specifically avoided against matching patterns like `%my_macro(){}`, since they may actually contain a reference to a struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using an "any struct match" (I don't know the proper term, sorry) causes errors being logged during indexing:
The code causing it is, for example:
This change adds proper handling to this kind of matches (ignoring them, as they are not useful, but without emitting an error).