fix(engine): correctly match any-struct references #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHGIJMKLKKZNPJKQR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that after upgrading to the current newest version (375391c) I still see a lot of the following log
The should be resolved after #343, but there is a small typo in one of the heads of
expand_alias(ast_node, reducer).I've hopefully fixed the issue for good by pattern matching against the AST representation of a variable in the appropriate head clause and adding tests for the log.
I've specifically avoided against matching patterns like
%my_macro(){}, since they may actually contain a reference to a struct.