fix(ports): move tx_initialize_low_level.S to example_build for M33/M55/M85 GNU#514
Open
nhuvaoanh123 wants to merge 1 commit intoeclipse-threadx:masterfrom
Conversation
…x-M33/M55/M85 GNU (eclipse-threadx#452) The Cortex-M33, M55, and M85 GNU ports incorrectly include tx_initialize_low_level.S as a library source in CMakeLists.txt. This file is board-specific initialization code that users must customize for their hardware, and including it in the library causes linker conflicts when users provide their own implementation (e.g., via CMake FetchContent). This change aligns these ports with the established pattern used by Cortex-M0/M3/M4/M7 GNU ports: - Move tx_initialize_low_level.S from src/ to example_build/ - Remove it from CMakeLists.txt target_sources - Add sample_threadx.c to example_build/ for consistency Signed-off-by: An Dao <webmaster@taktflow-systems.com>
nhuvaoanh123
force-pushed
the
fix/452-move-low-level-init-to-example-build
branch
from
5849440 to
210bc6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #452
The Cortex-M33, M55, and M85 GNU ports incorrectly include
tx_initialize_low_level.Sas a library source inCMakeLists.txt. This file is board-specific initialization code that users must customize for their hardware. Including it in the library causes linker conflicts (duplicate symbol_tx_initialize_low_level) when users provide their own implementation via CMakeFetchContent.This PR aligns these three ports with the established pattern used by Cortex-M0/M3/M4/M7 GNU ports:
tx_initialize_low_level.Sfromsrc/toexample_build/(reference template only)tx_initialize_low_level.Sentry fromCMakeLists.txttarget_sourcessample_threadx.ctoexample_build/for consistency with other portsCMakeLists.txtformatting with the{{BEGIN/END_TARGET_SOURCES}}markers used by other portsPorts affected
cortex_m33/gnusrc/+ in CMakeexample_build/onlycortex_m55/gnusrc/+ in CMakeexample_build/onlycortex_m85/gnusrc/+ in CMakeexample_build/onlyReference (correct pattern)
ports/cortex_m4/gnu/—tx_initialize_low_level.Sinexample_build/, not referenced inCMakeLists.txtTest plan
CMakeLists.txtno longer referencestx_initialize_low_level.Sexample_build/containstx_initialize_low_level.S+sample_threadx.cfor all three portsSigned-off-by: An Dao webmaster@taktflow-systems.com