Skip to content

Make org.eclipse.jsch.ui compatible with modern JSch versions #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptziegler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make org.eclipse.jsch.ui compatible with modern JSch versions #2580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
788abd3
Make `org.eclipse.jsch.ui` compatible with modern JSch versions
ptziegler Mar 19, 2026
38bc73c
Version bump(s) for 4.40 stream
eclipse-platform-bot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion team/bundles/org.eclipse.jsch.ui/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jsch.ui;singleton:=true
Bundle-Version: 1.6.0.qualifier
Bundle-Version: 1.6.100.qualifier
Bundle-Activator: org.eclipse.jsch.internal.ui.JSchUIPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
7 changes: 3 additions & 4 deletions ...ndles/org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/preference/PreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2025 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -742,8 +742,6 @@ public void widgetSelected(SelectionEvent e){
}
}

kpair.setPassphrase(pass);

String home=ssh2HomeText.getText();

File _home=new File(home);
Expand Down Expand Up @@ -777,7 +775,8 @@ public void widgetSelected(SelectionEvent e){

boolean ok=true;
try{
kpair.writePrivateKey(file);
byte[] passBytes = pass.isEmpty() ? null : pass.getBytes();
kpair.writePrivateKey(file, passBytes);
kpair.writePublicKey(file+".pub", kpairComment); //$NON-NLS-1$
}
catch(Exception ee){
Expand Down
Loading