Make org.eclipse.jsch.ui compatible with modern JSch versions#2580
Open
ptziegler wants to merge 2 commits intoeclipse-platform:masterfrom
Open
Make org.eclipse.jsch.ui compatible with modern JSch versions#2580ptziegler wants to merge 2 commits intoeclipse-platform:masterfrom
org.eclipse.jsch.ui compatible with modern JSch versions#2580ptziegler wants to merge 2 commits intoeclipse-platform:masterfrom
Conversation
This is a continuation of 07f86ab. On modern JSch versions, the call to `setPassphrase(...)` will always throw an `UnsupportedOperationException`. Instead of using this deprecated method (which is already deprecated in JSch 0.1.55), the pass-phrase should be passed as an additional argument when calling `writePrivateKey(...)`. To reproduce: Run the Eclipse IDE with e.g. `com.github.mwiede.jsch` in version 2.27.7. Then, open the SSH2 preference page, create a new RSA-key and then save the private key.
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of 07f86ab. On modern JSch versions, the call to
setPassphrase(...)will always throw anUnsupportedOperationException.Instead of using this deprecated method (which is already deprecated in JSch 0.1.55), the pass-phrase should be passed as an additional argument when calling
writePrivateKey(...).To reproduce: Run the Eclipse IDE with e.g.
com.github.mwiede.jschin version 2.27.7. Then, open the SSH2 preference page, create a new RSA-key and then save the private key.