Repository navigation
Return a query worker's plain result like PHP - #636
Merged
Merged
Conversation
Published PHP SDK workers complete a query task with the plain result and its envelope, and published PHP Server returns that plain result to the caller and in the control-plane envelope. Native required the envelope, dropped the plain result and answered result: null, so main's SDK query direction profile saw the published Python client's hydrated result differ from the wire response.
rmcdaniel
enabled auto-merge
October 22, 2026 04:17
|
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #325.
After #626, main's Shared Server fixtures still failed in
mysql-executionandpostgres-storage, in the SDK query directions profile (main run 39704552600). In the PHP-worker cases, the published Python client's hydrated response carried the query state incontrol_plane.result, while native's wire response hadnull.Cause
resultand itsresult_envelope.completeQueryTaskaccepts both and returns the plainresultbeside the envelope; its control-plane envelope copies it.result, and always answeredresult: null.What changes
result.resultwith no envelope is accepted, as PHP's rules allow. A completion with neither is still refused.Verification
control_plane.execution-and-codecalso failed on main, but its step log isn't reachable from my network path, so I can't yet confirm it shares this cause.Checkpoint:
docs/rust-server-port-checkpoints/2026-10-22-query-worker-result.md.