Repository navigation
Write the cancellation cleanup finish time like the run's closed_at - #626
Merged
Merged
Conversation
The WorkflowCancelled payload's cancellation_cleanup.finished_at was a raw chrono time, printed with three fractional digits, while the run's closed_at has six. Published Workflow writes it as closed_at->toISOString(), and the shared fixtures compare the two as text, so every native cancellation cell on main has failed since #561. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rmcdaniel
enabled auto-merge
October 22, 2026 00:17
|
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #325.
The Shared Server fixtures workflow has failed on main since #561. In main run 39671560431, every native cancellation cell (
codec-deadline-healthon all databases,execution-and-codec,mysql-execution,postgres-storage) fails the same assertion,cleanup closes at persisted terminal time:2026-10-21T23:12:52.433000Z: the run'sclosed_at;2026-10-21T23:12:52.433Z: theWorkflowCancelledpayload'scancellation_cleanup.finished_at.Native wrote
finished_atas a raw chrono time, which prints as few fractional digits as the value needs. Published Workflow writes it asclosed_at->toISOString()(six digits), andCancellationCascadeViewtreats a different string as a mismatch. It now uses the six-digit form, like thecleanup_deadline_atandrequested_atbeside it.Verification
…22.519Zagainst…22.519000Z) and passes with it.Not fixed here
postgres-storage (postgres-17)in the same run stopped earlier, in the operator metricswaiting_after_redispatchstage. Its health snapshot warneddurable_resume_pathswhile the metrics snapshot just before it counted no run needing repair. That is a timing difference between two requests. It is diagnosed separately once this assertion no longer hides it.Checkpoint:
docs/rust-server-port-checkpoints/2026-10-22-cleanup-finished-at.md.🤖 Generated with Claude Code