Skip to content

Fall back to ld for private libunwind partial link #129352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbomer wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

Fall back to ld for private libunwind partial link #129352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/coreclr/nativeaot/Runtime/Full/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,16 @@ if(NATIVEAOT_PRIVATE_LIBUNWIND_SOURCES)
NAMES "ld.lld${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_VERSION}${NATIVEAOT_PRIVATE_LIBUNWIND_LINKER_EXTENSION}" ld.lld
PATHS "${NATIVEAOT_PRIVATE_LIBUNWIND_TOOL_DIR}"
NO_DEFAULT_PATH)
if(NOT NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD)
message(FATAL_ERROR "ld.lld is required to privatize NativeAOT libunwind symbols")
if(NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD)
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD}")
else()
find_program(NATIVEAOT_PRIVATE_LIBUNWIND_LD NAMES ld)
if(NATIVEAOT_PRIVATE_LIBUNWIND_LD)
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD}")
else()
message(FATAL_ERROR "A linker supporting relocatable linking is required to privatize NativeAOT libunwind symbols")
endif()
endif()
set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD}")
endif()

add_custom_command(
Expand Down
Loading