Fall back to ld for private libunwind partial link#129352
Open
sbomer wants to merge 1 commit into
Open
Conversation
When CMAKE_LINKER resolves to llvm-link, continue preferring the matching ld.lld for the NativeAOT private libunwind partial link, but fall back to binutils ld when ld.lld is unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the NativeAOT private libunwind “partial link” tool selection logic so that when CMAKE_LINKER resolves to llvm-link, the build prefers a matching ld.lld but can fall back to ld if ld.lld isn’t available.
Changes:
- If
ld.lldmatching the detectedllvm-linkversion is found, use it for the-rpartial link step. - Otherwise, attempt to locate
ldand use it as a fallback linker; if neither is found, fail configuration with a fatal error.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/nativeaot/Runtime/Full/CMakeLists.txt | Updates linker selection for the libunwind relocatable/partial link step to prefer ld.lld but allow fallback to ld. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
| if(NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD) | ||
| set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD_LLD}") | ||
| else() | ||
| find_program(NATIVEAOT_PRIVATE_LIBUNWIND_LD NAMES ld) |
| if(NATIVEAOT_PRIVATE_LIBUNWIND_LD) | ||
| set(NATIVEAOT_PRIVATE_LIBUNWIND_LINKER "${NATIVEAOT_PRIVATE_LIBUNWIND_LD}") | ||
| else() | ||
| message(FATAL_ERROR "A linker supporting relocatable linking is required to privatize NativeAOT libunwind symbols") |
jkotas
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CMAKE_LINKER resolves to llvm-link, continue preferring the matching ld.lld for the NativeAOT private libunwind partial link, but fall back to binutils ld when ld.lld is unavailable.
Fixes #129313