Skip to content

Revert "[release/9.0-staging] Update dependencies from dotnet/roslyn …#125679

Merged
jozkee merged 1 commit intodotnet:release/9.0from
sbomer:revert-9.0
Mar 18, 2026
Merged

Revert "[release/9.0-staging] Update dependencies from dotnet/roslyn …#125679
jozkee merged 1 commit intodotnet:release/9.0from
sbomer:revert-9.0

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Mar 17, 2026

…(#121343)"

This reverts commit f505b94.

@sbomer sbomer requested a review from marek-safar as a code owner March 17, 2026 21:12
@sbomer sbomer requested review from Copilot and wtgodbe March 17, 2026 21:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the Roslyn dependency update on release/9.0-staging, restoring prior pinned versions and adjusting affected tests/source-build configuration to match the reverted compiler/analyzer behavior.

Changes:

  • Revert Roslyn / Roslyn-analyzers package versions in eng/Versions.props and eng/Version.Details.xml.
  • Update/normalize several test expected outputs and warning expectations to align with the reverted compiler/tooling behavior.
  • Remove Roslyn-specific ignore patterns from the source-build prebuilt baseline.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs Stops expecting a compiler-generated IL2062 warning that was tied to newer compiler codegen.
src/tools/illink/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj Switches the generator’s Roslyn package reference property.
src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs Updates expected fixed code formatting for top-level-statement scenarios.
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs Adjusts expected fixed output formatting (blank line) for BufferSize insertion.
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs Adjusts expected fixed output formatting (blank line) for BufferSize insertion.
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs Adjusts expected fixed output formatting (blank line) for BufferSize insertion.
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs Adjusts expected fixed output formatting (blank line) for BufferSize insertion.
eng/Versions.props Reverts Roslyn-related version properties and adds UsingToolMicrosoftNetCompilers behavior for VMR builds.
eng/Version.Details.xml Reverts Roslyn dependency versions/SHAs (and analyzer dependency metadata) to match the reverted state.
eng/SourceBuildPrebuiltBaseline.xml Removes Roslyn-dependency ignore patterns introduced by the reverted commit.

@jozkee
Copy link
Member

jozkee commented Mar 18, 2026

/ba-g known errors and a DeadLetter.

@jozkee jozkee merged commit b07b47c into dotnet:release/9.0 Mar 18, 2026
167 of 173 checks passed
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Mar 18, 2026
@github-project-automation github-project-automation bot moved this to Done in AppModel Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Runtime.InteropServices linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants