Revert "[release/9.0-staging] Update dependencies from dotnet/roslyn"#125668
Open
sbomer wants to merge 1 commit intorelease/9.0-stagingfrom
Open
Conversation
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a prior dependency update from dotnet/roslyn in the runtime repo, restoring earlier Roslyn/compilers/analyzers versions and aligning a few tests/baselines with the reverted toolchain behavior.
Changes:
- Downgrade Roslyn compiler/toolset and analyzer package versions in
eng/Versions.propsandeng/Version.Details.xml. - Update/adjust test expectations and formatting impacted by Roslyn/C# codegen and formatting differences.
- Remove source-build prebuilt baseline ignore patterns that were specific to the reverted Roslyn dependency set.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tools/illink/test/Mono.Linker.Tests.Cases/DataFlow/CompilerGeneratedCodeAccessedViaReflection.cs | Stops expecting an IL2062 warning tied to newer C# 14 codegen. |
| src/tools/illink/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj | Reverts the Roslyn package version property used by the test generator project. |
| src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs | Updates expected fixed-code formatting for top-level statements scenarios. |
| src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessValueShapeValidation.cs | Adjusts expected formatting (blank line) in test input/output. |
| src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatelessLinearCollectionShapeValidation.cs | Adjusts expected formatting (blank line) in test input/output. |
| src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulValueShapeValidation.cs | Adjusts expected formatting (blank line) in test input/output. |
| src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/CustomMarshallerAttributeFixerTests_StatefulLinearCollectionShapeValidation.cs | Adjusts expected formatting (blank line) in test input/output. |
| eng/Versions.props | Reverts Roslyn/analyzers/toolset versions and adds a build property related to compiler selection. |
| eng/Version.Details.xml | Reverts Roslyn dependency versions/SHAs and adjusts analyzer dependency source metadata. |
| eng/SourceBuildPrebuiltBaseline.xml | Removes Roslyn-specific prebuilt ignore patterns that were introduced with the reverted update. |
...link/test/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.Generator.csproj
Show resolved
Hide resolved
Member
|
Shouldn't we merge this directly into rel/9.0 to unblock the build? |
Member
Author
|
Ported to release/9.0: #125679 |
agocke
previously approved these changes
Mar 17, 2026
Member
|
@sbomer Can you remove the source code changes? That way we can make this test-only and it's tell-mode. |
agocke
approved these changes
Mar 17, 2026
Member
agocke
left a comment
agocke
left a comment
There was a problem hiding this comment.
nvm, misread the file name. This is all test code. LGTM
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #121343