Skip to content

Fix flaky test failure in HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs (#7148) #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iamitprakash wants to merge 1 commit into from
Closed

Fix flaky test failure in HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs (#7148) #7328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware.Tests/Logging/AcceptanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,9 @@ await RunAsync<TestStartup>(
// 1st log record is from DfaMatcher,
// 2, 3, 4th are from our "test" category
// and 5 and 6th are logs from the /logatrequest endpoint
Assert.Equal(6, logCollector.Count);
var entries = logCollector.GetSnapshot();
var relevantCount = entries.Count(x => x.Category == "Microsoft.AspNetCore.Routing.Matching.DfaMatcher" || x.Category == "test" || x.Category == "logatrequest");
Assert.Equal(6, relevantCount);
Assert.Equal(LogLevel.Trace, logCollector.LatestRecord.Level);
Assert.Equal("test", logCollector.LatestRecord.Category);
});
Expand Down
Loading