Fix flaky test failure in HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs (#7148)#7328
Closed
iamitprakash wants to merge 1 commit intodotnet:mainfrom
Closed
Fix flaky test failure in HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs (#7148)#7328iamitprakash wants to merge 1 commit intodotnet:mainfrom
iamitprakash wants to merge 1 commit intodotnet:mainfrom
Conversation
…rOversizedLogs (Issue dotnet#7148)
Member
|
Thanks, but there's already a pr for this at #7304...? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky test failure in
HttpRequestBuffering_DoesNotBufferDisabledOrOversizedLogs
where the test occasionally received 7 logs instead of the expected 6.
Changes
Updated the assertion in
AcceptanceTests.cs
to explicitly filter for the log categories intended by the test case: Microsoft.AspNetCore.Routing.Matching.DfaMatcher, test, and logatrequest.
This prevents environmental noise or default HttpLoggingMiddleware logs from causing intermittent failures.
Fixes #7148
Microsoft Reviewers: Open in CodeFlow