Skip to content

Fix root directory logic for tilde links - #32

Merged
gewarren merged 1 commit into
dotnet:mainfrom
gewarren:tilde-links
Oct 15, 2026
Merged

gewarren merged 1 commit into
dotnet:mainfrom
gewarren:tilde-links

Conversation

@gewarren

@gewarren gewarren commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Instead of constructing ~/ links relative to the repo root, construct them relative to directory that contains the nearest ancestor docfx.json file.

For example of failure, see https://github.com/dotnet/AspNetCore.Docs/actions/runs/38653881842/job/116158918671?pr=37890.

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren
gewarren merged commit dc6c4bf into dotnet:main Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants