Repository navigation
Verify ~ (tilde) links with MSDocs Verifier workflow - #37890
Merged
Merged
Conversation
Updated the excludeStartingWith list to include '~/../'.
gewarren
enabled auto-merge (squash)
October 14, 2026 23:25
gewarren
marked this pull request as draft
October 14, 2026 23:27
auto-merge was automatically disabled
October 14, 2026 23:27
Pull request was converted to draft
Collaborator
Author
|
Looks like I need to fix the docs-verifier tool first. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pinned verifier resolves tilde-prefixed links against the repository root, causing valid docset-relative links to fail validation.
1 open finding
What changed in this PR
This PR narrows link-verifier exclusions to enable checking docset-relative links in ASP.NET Core documentation.
Changes:
- Replaces the
~/exclusion with~/../, preserving exclusions for cross-repository links.
| File | Description |
|---|---|
aspnetcore/markdown-links-verifier-config.json |
Narrows the tilde-prefixed link exclusion. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
guardrex
approved these changes
Oct 15, 2026
gewarren
changed the title
gewarren
marked this pull request as ready for review
October 16, 2026 01:42
guardrex
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only exclude links that start with ~ if they point to a link in a different repo, in which case the pattern is
~/../. We should verify all other ~ links since this repo uses them extensively.Internal previews
Toggle expand/collapse
Build report