Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions src/BenchmarkDotNet/Helpers/FileCleanupHelper.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
namespace BenchmarkDotNet.Helpers;

internal static class FileCleanupHelper
{
public static void Cleanup(string path)
{
if (File.Exists(path))
{
CleanupFile(new FileInfo(path));
return;
}

if (Directory.Exists(path))
{
CleanupDirectory(new DirectoryInfo(path));
}
}

private static void CleanupFile(FileInfo fileInfo)
{
TryExecute(() =>
{
File.SetAttributes(fileInfo.FullName, FileAttributes.Normal);
File.Delete(fileInfo.FullName);
});
}

private static void CleanupDirectory(DirectoryInfo directoryInfo)
{
// Delete files
foreach (var file in EnumerateFiles(directoryInfo))
{
CleanupFile(file);
}

// Delete sub directories
foreach (var subDirectory in EnumerateSubDirectories(directoryInfo))
{
CleanupDirectory(subDirectory);
}

// Delete directory
TryExecute(() => directoryInfo.Delete(recursive: false));
}

private static void TryExecute(Action action)
{
try
{
action();
}
catch
{
// Ignore exceptions for access denied, in use, etc.
}
}

#if NETSTANDARD2_0
private static IEnumerable<FileInfo> EnumerateFiles(DirectoryInfo directory)
=> TryExecute(() => directory.EnumerateFiles("*", SearchOption.TopDirectoryOnly), []);

private static IEnumerable<DirectoryInfo> EnumerateSubDirectories(DirectoryInfo directory)
=> TryExecute(() => directory.EnumerateDirectories(), []);

private static T TryExecute<T>(Func<T> func, T fallback)
{
try
{
return func();
}
catch
{
// Ignore exceptions for access denied, in use, etc.
return fallback;
}
}
#else
private static readonly EnumerationOptions EnumerationOptions = new()
{
RecurseSubdirectories = false,
IgnoreInaccessible = true,
AttributesToSkip = FileAttributes.ReparsePoint
};

private static IEnumerable<FileInfo> EnumerateFiles(DirectoryInfo directory)
=> directory.EnumerateFiles("*", EnumerationOptions);

private static IEnumerable<DirectoryInfo> EnumerateSubDirectories(DirectoryInfo currentDir)
=> currentDir.EnumerateDirectories("*", EnumerationOptions);
#endif
}
17 changes: 1 addition & 16 deletions src/BenchmarkDotNet/Running/BenchmarkRunnerClean.cs
Original file line number Diff line number Diff line change
Expand Up @@ -808,22 +808,7 @@ private static void Cleanup(ILogger logger, HashSet<string> artifactsToCleanup)
{
foreach (string path in artifactsToCleanup)
{
try
{
if (Directory.Exists(path))
{
Directory.Delete(path, recursive: true);
}
else if (File.Exists(path))
{
File.Delete(path);
}
}
catch (Exception)
{
// sth is locking our auto-generated files
// there is very little we can do about it
}
FileCleanupHelper.Cleanup(path);
}
}

Expand Down
4 changes: 4 additions & 0 deletions src/BenchmarkDotNet/Toolchains/GeneratorBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ public async ValueTask<GenerateResult> GenerateProjectAsync(BuildPartition build
{
artifactsPaths = GetArtifactsPaths(buildPartition, rootArtifactsFolderPath);

// Cleanup artifact files/directories before generating project files.
foreach (var path in GetArtifactsToCleanup(artifactsPaths))
FileCleanupHelper.Cleanup(path);

// There is no async file copy API, so we just do it synchronously. We are likely on a ThreadPool thread here anyway if this generator is ran in parallel.
CopyAllRequiredFiles(artifactsPaths);

Expand Down
Loading