feat: Add cleanup logic for workdirectory before build projects#3175
Open
filzrev wants to merge 1 commit into
Open
feat: Add cleanup logic for workdirectory before build projects#3175filzrev wants to merge 1 commit into
filzrev wants to merge 1 commit into
Conversation
timcassell
reviewed
Jun 17, 2026
| { | ||
| var buildArtifactsDirectoryName = new DirectoryInfo(artifactsPaths.BuildArtifactsDirectoryPath).Name; | ||
|
|
||
| // Check directory name to skip BenchmarkDotNet.Toolchains.Roslyn.Generator |
Collaborator
There was a problem hiding this comment.
Instead of checking this way, you could make this method virtual and override it in DotNetCliGenerator.
Contributor
Author
There was a problem hiding this comment.
I've simplified code to cleanup files/directories that are returned by existing GetArtifactsToCleanup method.
filzrev
force-pushed
the
feat-add-workdirectory-cleanup-before-build
branch
2 times, most recently
from
1bcb9c1 to
e814c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #3174
What's changed in this PR
FileCleanupHelperhelper classGeneratorBase.csand add cleanup logics for files/directories that returned byGetArtifactsToCleanupBenchmarkRunnerClean.cslogics to support following scenario.3.1 Delete file that have
ReadOnlyattribute (on Windows)3.2. Continue processing when exception occurred.