Plugins: drop the options and weight entry fields - #2799
Merged
chalin merged 8 commits intoSep 9, 2026
Merged
Conversation
Site-side options and weight on a plugin entry must produce the docsy-config unknown-field warning while the entry still applies. Fails until the schema drops both fields.
Plugin entries are now `{defer, enable, version}`. Nothing shipped with the
theme read `weight`, and MarkMap's `height` was the only `options` reader;
its map returns to the fixed 300px style. The loop drops the options
normalization and warning, the weight cast and sort, and the `params`
js.Build option (no more `@params` transport); entries emit in the range's
key order. Unreleased fields, so no changelog entry.
Plugin fixtures no longer import @params; the companion case reads .Plugin.version, theme inheritance rides a version, the weight-order case becomes a determinism check, and the MarkMap height cases collapse into a fixed-rule assertion. The options-shape cases are gone with the field.
User guide: drop the weight reference bullets, the @params file-table cell and key-spelling aside, the options-specific security bullets, and MarkMap's height option (the map is 300px). Design page: the pin never reaches JS; name order is an implementation detail, not a contract. Quality page: loop-contract and runtime-net descriptions follow.
The implementation page still listed a sorting step before the shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{defer, enable, version}optionsandweightdeleted from the schema, the loop, and MarkMap's script; a site value on either now trips thedocsy-configunknown-field warningweightdeferand loading strategy (next PR); per-map sizing (Is it possible to adjust the height of a rendered markmap? #1144, Markmap diagrams: various improvements #1365); changelog and 0.18 post (neither field was released)