Skip to content

Complete reviewed DotMatch 0.3.0 integrations - #93

Merged
dnncha merged 4 commits into
mainfrom
codex/dotmatch-0.3.0-candidate
Aug 29, 2026
Merged

Complete reviewed DotMatch 0.3.0 integrations#93
dnncha merged 4 commits into
mainfrom
codex/dotmatch-0.3.0-candidate

Conversation

@dnncha

@dnncha dnncha commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

Completes the reviewed 0.3.0 candidate after #91 merged its earlier head.

  • adds reproducible, checksummed assay handoff bundles without copying raw reads
  • updates supported GitHub Actions and site type-checking dependencies
  • aligns the Pages readiness checker with actions/deploy-pages@v5
  • adds literal-alphabet indexed-vs-scan fuzz coverage
  • aligns the site lockfile version with 0.3.0

This carries the compatible changes reviewed from #75, #76, and #85, plus the bounded native regression test from #84. It does not merge broader planning or unvalidated claim material.

Verification

  • initial 0.3.0 candidate: native, CLI, ASan/UBSan, 614 Python tests (2 skipped), package install smoke, documentation-as-errors, repository/release/scientific/evidence gates, and coverage all passed before the site toolchain precondition
  • focused integrated checks: 3 handoff tests, 28 repository-readiness tests, native tests, TypeScript lint, site asset checks, static site build, and npm audit passed
  • exact-head CI and workflow-ecosystem runs are in progress for 53242f1499b8089e71b70e337f54f7b2c3430894

The local full rerun was stopped cleanly at 563 passed / 2 skipped under the shared low-disk hold. No source was lost; exact-head remote CI is the completion authority while local disk remains near the 10 GiB hard floor.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T22:38:11.708541Z 53242f1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

dnncha and others added 4 commits August 29, 2026 23:33
Bumps the actions group with 3 updates in the / directory: [actions/setup-python](https://github.com/actions/setup-python), [actions/deploy-pages](https://github.com/actions/deploy-pages) and [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel).


Updates `actions/setup-python` from 6 to 7
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v6...v7)

Updates `actions/deploy-pages` from 4 to 5
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](actions/deploy-pages@v4...v5)

Updates `pypa/cibuildwheel` from 4.1.0 to 4.2.0
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](pypa/cibuildwheel@v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: actions/deploy-pages
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: actions/setup-python
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: pypa/cibuildwheel
  dependency-version: 4.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps the site-dependencies group with 4 updates in the / directory: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node), [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react), [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) and [typescript](https://github.com/microsoft/TypeScript).


Updates `@types/node` from 25.9.1 to 26.2.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@types/react` from 19.2.16 to 19.2.18
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

Updates `@types/react-dom` from 19.2.3 to 19.2.5
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

Updates `typescript` from 6.0.3 to 7.0.2
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v6.0.3...v7.0.2)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.2.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: site-dependencies
- dependency-name: "@types/react"
  dependency-version: 19.2.18
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: site-dependencies
- dependency-name: "@types/react-dom"
  dependency-version: 19.2.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: site-dependencies
- dependency-name: typescript
  dependency-version: 7.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: site-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Donncha O'Toole <dnncha@gmail.com>
@dnncha
dnncha force-pushed the codex/dotmatch-0.3.0-candidate branch from 53242f1 to f2d7f20 Compare August 29, 2026 22:33
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

("reads", str(assay.data["reads"])),

P2 Badge Collect both FASTQs in paired-assay handoffs

When a completed pair-count AssaySpec uses the newly supported left_reads/right_reads layout, reads is absent, so this lookup raises KeyError and dotmatch assay handoff fails after partially creating its output directory. Build the input list from both mate paths when the spec has no single reads entry.


#set $sample_label = re.sub(r'(?i)\.(?:fastq|fastqsanger)(?:\.gz)?$', '', str($sample.element_identifier))
#set $sample_id = re.sub(r'[^\w.-]', '_', str($sample_label))
#if $sample.is_of_type('fastq.gz', 'fastqsanger.gz'):
#set $fastq_name = $sample_id + '.fastq.gz'

P2 Badge Make generated Galaxy sample IDs unique

When two selected Galaxy datasets have names that become identical after suffix removal and sanitization—for example sample a.fastq and sample@a.fastq—both produce the same sample ID and staged FASTQ name. The second ln -s then fails because the destination already exists; even without that collision, crispr-count rejects duplicate sample labels. Add a deterministic unique suffix or reject collisions with a clear validation error.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dnncha
dnncha merged commit fce7415 into main Aug 29, 2026
20 of 21 checks passed
@dnncha
dnncha deleted the codex/dotmatch-0.3.0-candidate branch August 29, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant