Skip to content

Fix ros-dev install - #3888

Open
Dreamsorcerer wants to merge 1 commit into
mainfrom
fix-ros-dev
Open

Fix ros-dev install#3888
Dreamsorcerer wants to merge 1 commit into
mainfrom
fix-ros-dev

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

The comments may be causing problems with line continuation (which maybe asks if we even need the extra 2 dependencies that were not being installed at all; I only need the cyclone one).

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This change separates package-specific comments from the continued apt-get install command in docker/python/Dockerfile. A no-cache build of the updated Dockerfile and a comment-free control both completed successfully. Runtime inspection confirmed that iproute2, liblcm-dev, libturbojpeg0-dev, and cyclonedds-dev are installed in both images. No defects were found.

Confidence Score: 5/5

Safe to merge: the updated Dockerfile builds cleanly and produces an image with every required package installed.

Direct no-cache builds and runtime package checks exercised the changed installation command and found no failure or package omission.

Files Needing Attention: No files need further attention.

T-Rex T-Rex Logs

What T-Rex did

  • Built a control Docker image from the comment-free Dockerfile and the checked-out docker/python/Dockerfile using Docker with no build cache.
  • Both Docker builds exited with status 0 and showed no provisioning or security consequences.
  • Runtime inspections confirmed iproute2, liblcm-dev, libturbojpeg0-dev, and cyclonedds-dev were installed at identical versions across the builds.
  • The changed package-install command was exercised and Docker parsed it successfully with all required packages included.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Fix ros-dev install" | Re-trigger Greptile

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3888   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files        1329     1329           
  Lines      126868   126868           
  Branches    11035    11035           
=======================================
  Hits        98746    98746           
  Misses      24971    24971           
  Partials     3151     3151           
Flag Coverage Δ
OS-ubuntu-24.04-arm 74.54% <ø> (+<0.01%) ⬆️
OS-ubuntu-latest 75.08% <ø> (ø)
Py-3.10 75.07% <ø> (-0.01%) ⬇️
Py-3.11 75.07% <ø> (ø)
Py-3.12 75.07% <ø> (-0.01%) ⬇️
Py-3.13 75.07% <ø> (-0.01%) ⬇️
Py-3.14 75.07% <ø> (+<0.01%) ⬆️
Py-3.14t 75.07% <ø> (-0.01%) ⬇️
SelfHosted-Large 30.20% <ø> (ø)
SelfHosted-Linux 34.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 2, 2026
@spomichter
spomichter added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants